Re: [Qemu-devel] [PATCH v4 03/10] tests: Add vm test lib

[Philippe Mathieu-Daudé]

On 08/30/2017 12:34 AM, Fam Zheng wrote:
> On Tue, 08/29 14:34, Philippe Mathieu-Daudé wrote:
> > > +        self._args = [ \
> > > +            "-nodefaults", "-m", "2G",
> > > +            "-cpu", "host",
> > > +            "-netdev", "user,id=vnet,hostfwd=:0.0.0.0:0-:22",
> > > +            "-device", "virtio-net-pci,netdev=vnet",
> > > +            "-vnc", ":0,to=20",
> > > +            "-serial", "file:%s" % os.path.join(self._tmpdir, "serial.out")]
> > > +        if vcpus:
> > > +            self._args += ["-smp", str(vcpus)]
> >
> > What about enabling mttcg which isn't default?
> >
> >              self._args += ["--accel", "tcg,thread=multi"]
>
> Any specific reason to enable it? I think it is not available on older QEMU.

Neither is dynamic portfwd :)

I see 2 reasons:
- faster test
- cover mttcg

> > > +        if os.access("/dev/kvm", os.R_OK | os.W_OK):
> > > +            self._args += ["-enable-kvm"]
> > > +        else:
> > > +            logging.info("KVM not available, not using -enable-kvm")
> > > +        self._data_args = []
> > [...]
>
> Fam