Re: [Qemu-devel] [PATCH v6 04/29] qtest: Don't perform side effects inside assertion

[Thomas Huth]

On 01.09.2017 20:03, Eric Blake wrote:
> Assertions should be separate from the side effects, since in
> theory, g_assert() can be disabled (in practice, we can't really
> ever do that).
> 
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  qtest.c | 80 
> ++++++++++++++++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 57 insertions(+), 23 deletions(-)

Right, we should get rid of this bad coding style in the QEMU sources.

Reviewed-by: Thomas Huth <address@hidden>