Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock update prints to warn_report

[Philippe Mathieu-Daudé]

(Cc'ing Yongbok and Aurelien from get_maintainer.pl)

On 09/11/2017 04:52 PM, Alistair Francis wrote:
> Convert the fprintf() messages in kvm_mips_update_state() to use
> warn_report() as they aren't errors, but are just warnings.
>
> Signed-off-by: Alistair Francis <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> Cc: James Hogan <address@hidden>
> ---
>
>   target/mips/kvm.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/mips/kvm.c b/target/mips/kvm.c
> index a23aa438d2..3b7b1d962a 100644
> --- a/target/mips/kvm.c
> +++ b/target/mips/kvm.c
> @@ -526,7 +526,7 @@ static void kvm_mips_update_state(void *opaque, int 
> running, RunState state)
>           if (!cs->vcpu_dirty) {
>               ret = kvm_mips_save_count(cs);
>               if (ret < 0) {
> -                fprintf(stderr, "Failed saving count\n");
> +                warn_report("Failed saving count");
>               }
>           }
>       } else {
> @@ -535,14 +535,14 @@ static void kvm_mips_update_state(void *opaque, int 
> running, RunState state)
>           ret = kvm_mips_put_one_ureg64(cs, KVM_REG_MIPS_COUNT_RESUME,
>                                         &count_resume);
>           if (ret < 0) {
> -            fprintf(stderr, "Failed setting COUNT_RESUME\n");
> +            warn_report("Failed setting COUNT_RESUME");
>               return;
>           }
>   
>           if (!cs->vcpu_dirty) {
>               ret = kvm_mips_restore_count(cs);
>               if (ret < 0) {
> -                fprintf(stderr, "Failed restoring count\n");
> +                warn_report("Failed restoring count");
>               }
>           }
>       }