[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames |
Date: |
Tue, 12 Sep 2017 09:57:50 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Mon, Sep 11, 2017 at 12:04:15PM -0700, Brandon Carpenter wrote:
> On Mon, Sep 11, 2017 at 10:10 AM, Daniel P. Berrange <address@hidden>
> wrote:
> > It feels like this is still dangerous - the client simply has to
> > interleave each "ping" with a 1 byte binary frame to get around this
> > limit. We need to make sure we have an absolute cap on the output buffer
> > size.
>
> Okay. I see that now that I look at it more closely. This breed of
> asynchronous I/O is tricky because the conditions for reading/writing are
> all over the place. There's a lot of context to keep in your head.
>
> I have a fix. And I realized that I was missing a patch in the series for
> RFC-compliant closing of websocket connections, which I must have lost
> during a rebase. Should I submit v3 of the patch series or just add those
> patches to this thread?
It is generally preferred practice to submit new top level threads, rather
than sending more patches to a previous thread.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v2 2/6] io: Small updates in preparation for websocket changes, (continued)
- Message not available
- Message not available
- Message not available
Message not available
- [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Brandon Carpenter, 2017/09/08
- Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Daniel P. Berrange, 2017/09/11
- Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Brandon Carpenter, 2017/09/11
- Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Daniel P. Berrange, 2017/09/11
- Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Brandon Carpenter, 2017/09/11
- Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames,
Daniel P. Berrange <=
Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Daniel P. Berrange, 2017/09/11
Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Brandon Carpenter, 2017/09/11
Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Daniel P. Berrange, 2017/09/12
Re: [Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames, Brandon Carpenter, 2017/09/12
Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully support the RFC, Eric Blake, 2017/09/08