[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via dev
|
From: |
Igor Mammedov |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug via device_add |
|
Date: |
Tue, 12 Sep 2017 15:55:02 +0200 |
On Mon, 11 Sep 2017 17:21:29 +0200
David Hildenbrand <address@hidden> wrote:
> The first patches are a bunch of cleanups. I decided to go the
> extra mile and implement CPU hotplug via "device_add", as well as
> "query-hotpluggable-cpus".
>
> On s390x, only complete cores can be plugged. CPU hot unplug is currently
> not supported by the architecture.
>
> Support for hotplugging CPUs in random core-id order (last two patches)
> is added. We once hat a KVM bug preventing this, but the stable patch
> should now be included in relevant places - 152e9f65d66f ("KVM: s390: fix
> wrong lookup of VCPUs by array index"). Current tooling will plug them in
> sequential order anyway, so it should not hurt.
do you plan to convert hw/s390x/s390-virtio.c machine to possible_cpus as well?
it's not necessary to enable hotplug on it but sharing code and initializing
cpus the same way would be plus.
[...]