[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests |
Date: |
Wed, 13 Sep 2017 08:47:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 12.09.2017 16:44, Paolo Bonzini wrote:
> The purpose of this series is to separate the "check" sources from
> the tests. After these patches, common.config is reduced to simple
> shell initialization, and common.rc is only included by the tests.
>
> Along the way, a lot of dead code is removed too.
>
> In v2, the following patches:
>
> qemu-iotests: do not do useless search for QEMU_*_PROG
> qemu-iotests: do not search for binaries in the current directory
> qemu-iotests: include common.env and common.config early
>
> have been replaced by "qemu-iotests: cleanup and fix search for programs",
> which also preserves the behavior of searching for programs as symlinks
> in the current directory.
>
> Paolo
>
> Paolo Bonzini (10):
> qemu-iotests: remove dead code
> qemu-iotests: get rid of AWK_PROG
> qemu-iotests: move "check" code out of common.rc
> qemu-iotests: cleanup and fix search for programs
> qemu-iotests: limit non-_PROG-suffixed variables to common.rc
> qemu-iotests: do not include common.rc in "check"
> qemu-iotests: disintegrate more parts of common.config
> qemu-iotests: fix uninitialized variable
> qemu-iotests: get rid of $iam
> qemu-iotests: merge "check" and "common"
>
> tests/qemu-iotests/039.out | 10 +-
> tests/qemu-iotests/061.out | 4 +-
> tests/qemu-iotests/137.out | 2 +-
> tests/qemu-iotests/check | 575
> ++++++++++++++++++++++++++++++++++-----
> tests/qemu-iotests/common | 459 -------------------------------
> tests/qemu-iotests/common.config | 206 +-------------
> tests/qemu-iotests/common.qemu | 1 +
> tests/qemu-iotests/common.rc | 205 +++++++-------
Meta comment: Could we maybe also rename "tests/qemu-iotests" to
"tests/iotests" ? The "qemu" prefix sounds always very superfluous to me
here...
Thomas
- [Qemu-devel] [PATCH 07/10] qemu-iotests: disintegrate more parts of common.config, (continued)
- [Qemu-devel] [PATCH 07/10] qemu-iotests: disintegrate more parts of common.config, Paolo Bonzini, 2017/09/12
- [Qemu-devel] [PATCH 05/10] qemu-iotests: limit non-_PROG-suffixed variables to common.rc, Paolo Bonzini, 2017/09/12
- [Qemu-devel] [PATCH 09/10] qemu-iotests: get rid of $iam, Paolo Bonzini, 2017/09/12
- [Qemu-devel] [PATCH 08/10] qemu-iotests: fix uninitialized variable, Paolo Bonzini, 2017/09/12
- [Qemu-devel] [PATCH 10/10] qemu-iotests: merge "check" and "common", Paolo Bonzini, 2017/09/12
- Re: [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests,
Thomas Huth <=