Re: [Qemu-devel] [PATCH v2] tests: Introduce generic device hot-plug/hot-unplug functions

[Peter Xu]

On Wed, Sep 13, 2017 at 08:40:54PM +0200, Thomas Huth wrote:
> A lot of tests provide code for adding and removing a device via the
> device_add and device_del QMP commands. Maintaining this code in so many
> places is cumbersome and error-prone (some of the code parts check the
> responses for device deletion in an incorrect way, for example, we've got
> to deal with both, error code and DEVICE_DEL event here). So let's provide
> some proper generic functions for adding and removing a device instead.
> 
> The code for correctly unplugging a device has been taken from a patch
> from Peter Xu.
> 
> Signed-off-by: Thomas Huth <address@hidden>

Reviewed-by: Peter Xu <address@hidden>

I verified that this patch passes the "make check" either on master
branch or my private branch (which broke before this one). So:

Tested-by: Peter Xu <address@hidden>

Thanks!

-- 
Peter Xu