Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory

[Peter Xu]

On Wed, Sep 13, 2017 at 09:58:04AM +0200, Cornelia Huck wrote:
> On Tue, 12 Sep 2017 12:17:51 +0200
> Marc-André Lureau <address@hidden> wrote:
> 
> > Hi Peter
> > 
> > On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu <address@hidden> wrote:
> > > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote:  
> > >> It does not really make sense to dump memory that is not there.
> > >>
> > >> Moreover, that fixes a segmentation fault when calling dump-guest-memory
> > >> with no filter for a machine with no memory defined.
> > >>
> > >> New behaviour is:
> > >>
> > >> (qemu) dump-guest-memory /dev/null
> > >> dump: no guest memory to dump
> > >> (qemu) dump-guest-memory /dev/null 0 4096
> > >> dump: no guest memory to dump
> > >>
> > >> Signed-off-by: Cornelia Huck <address@hidden>
> > >> ---
> > >>
> > >> Another unmaintained file. Joy. cc:ing some more-or-less random folks.  
> > >
> > > I thought Marc-André had proposed to be the maintainer? But indeed I
> > > didn't see the line in maintainer file.
> > >
> > > Anyway, if anyone think I am ok to maintain this single file
> > > (considering that I haven't posted patches on it for 2 years, and I
> > > haven't been working on any kind of maintainer job), please let me
> > > know. I'm glad to start with it (or with Marc-André).
> > >  
> > 
> > That would be great!
> > thanks
> 
> Now on to the most important question: Will you merge this patch? :)
> 
> (It should probably go together with "tests/hmp: test "none" machine
> with memory".)

I posted a RFC to maintain this file with Marc-André Lureau, but not
getting any acks yet, so I guess at least I don't have that
permission, yet...

And I see Laruent posted this already:

  [Qemu-devel] [PATCH v4 0/4] hmp: fix "dump-quest-memory" segfault

So I assume all these four patches can go with Dave's tree.  Thanks,

-- 
Peter Xu