Re: [Qemu-devel] [PATCH] accel/hax: move hax-stub.c to accel/stubs/

[Paolo Bonzini]

On 14/09/2017 05:30, Stefan Weil wrote:
> Am 14.09.2017 um 00:11 schrieb Philippe Mathieu-Daudé:
>> Suggested-by: Paolo Bonzini <address@hidden>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>> ---
>>  Makefile.target                      | 1 -
>>  hax-stub.c => accel/stubs/hax-stub.c | 0
>>  accel/stubs/Makefile.objs            | 1 +
>>  3 files changed, 1 insertion(+), 1 deletion(-)
>>  rename hax-stub.c => accel/stubs/hax-stub.c (100%)
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 6361f957fb..af4b60d012 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -101,7 +101,6 @@ obj-y += fpu/softfloat.o
>>  obj-y += target/$(TARGET_BASE_ARCH)/
>>  obj-y += disas.o
>>  obj-$(call notempty,$(TARGET_XML_FILES)) += gdbstub-xml.o
>> -obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
>>  
>>  obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decContext.o
>>  obj-$(CONFIG_LIBDECNUMBER) += libdecnumber/decNumber.o
>> diff --git a/hax-stub.c b/accel/stubs/hax-stub.c
>> similarity index 100%
>> rename from hax-stub.c
>> rename to accel/stubs/hax-stub.c
>> diff --git a/accel/stubs/Makefile.objs b/accel/stubs/Makefile.objs
>> index fdfbf7332c..8038ad6553 100644
>> --- a/accel/stubs/Makefile.objs
>> +++ b/accel/stubs/Makefile.objs
>> @@ -1,2 +1,3 @@
>>  obj-$(call lnot,$(CONFIG_KVM)) += kvm-stub.o
>>  obj-$(call lnot,$(CONFIG_TCG)) += tcg-stub.o
>> +obj-$(call lnot,$(CONFIG_HAX)) += hax-stub.o
> 
> Reviewed-by: Stefan Weil <address@hidden>
> 
> Personally, I like alphabetic order for such lines.
> Maybe that can be done when it is applied.

Done and queued, thanks both.

Paolo