[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/11] hw/ide/microdrive: Mark the dscm1xxxx device w
From: |
John Snow |
Subject: |
[Qemu-devel] [PULL 02/11] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false |
Date: |
Fri, 15 Sep 2017 21:03:21 -0400 |
From: Thomas Huth <address@hidden>
QEMU currently aborts with an assertion message when the user is trying
to remove a dscm1xxxx again:
$ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic
QEMU 2.9.93 monitor - type 'help' for more information
(qemu) device_add dscm1xxxx,id=xyz
(qemu) device_del xyz
**
ERROR:qemu/qdev-monitor.c:872:qdev_unplug: assertion failed: (hotplug_ctrl)
Aborted (core dumped)
Looks like this device has to be wired up in code and is not meant
to be hot-pluggable, so let's mark it with user_creatable = false.
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: John Snow <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>
---
hw/ide/microdrive.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/ide/microdrive.c b/hw/ide/microdrive.c
index e3fd30e..17917c0 100644
--- a/hw/ide/microdrive.c
+++ b/hw/ide/microdrive.c
@@ -575,12 +575,15 @@ PCMCIACardState *dscm1xxxx_init(DriveInfo *dinfo)
static void dscm1xxxx_class_init(ObjectClass *oc, void *data)
{
PCMCIACardClass *pcc = PCMCIA_CARD_CLASS(oc);
+ DeviceClass *dc = DEVICE_CLASS(oc);
pcc->cis = dscm1xxxx_cis;
pcc->cis_len = sizeof(dscm1xxxx_cis);
pcc->attach = dscm1xxxx_attach;
pcc->detach = dscm1xxxx_detach;
+ /* Reason: Needs to be wired-up in code, see dscm1xxxx_init() */
+ dc->user_creatable = false;
}
static const TypeInfo dscm1xxxx_type_info = {
--
2.9.5
- [Qemu-devel] [PULL 00/11] Ide patches, John Snow, 2017/09/15
- [Qemu-devel] [PULL 02/11] hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false,
John Snow <=
- [Qemu-devel] [PULL 04/11] IDE: Add register hints to tracing, John Snow, 2017/09/15
- [Qemu-devel] [PULL 03/11] IDE: replace DEBUG_IDE with tracing system, John Snow, 2017/09/15
- [Qemu-devel] [PULL 10/11] AHCI: pretty-print FIS to buffer instead of stderr, John Snow, 2017/09/15
- [Qemu-devel] [PULL 09/11] AHCI: Rework IRQ constants, John Snow, 2017/09/15
- [Qemu-devel] [PULL 05/11] IDE: add tracing for data ports, John Snow, 2017/09/15
- [Qemu-devel] [PULL 01/11] ide: ahci: unparent children buses before freeing their memory, John Snow, 2017/09/15
- [Qemu-devel] [PULL 06/11] ATAPI: Replace DEBUG_IDE_ATAPI with tracing events, John Snow, 2017/09/15
- [Qemu-devel] [PULL 07/11] IDE: replace DEBUG_AIO with trace events, John Snow, 2017/09/15
- [Qemu-devel] [PULL 11/11] AHCI: remove DPRINTF macro, John Snow, 2017/09/15
- [Qemu-devel] [PULL 08/11] AHCI: Replace DPRINTF with trace-events, John Snow, 2017/09/15