[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export target A
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export target AS from address_space_translate_internal |
Date: |
Tue, 19 Sep 2017 10:15:34 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 19/09/17 00:28, Eric Blake wrote:
> On 09/18/2017 05:16 AM, Alexey Kardashevskiy wrote:
>
> Subject line: s/Explicitely/Explicitly/
>
>> This is not so mechanical change in order to move to shared FlatViews
>> so make it a separate patch.
>
> Hard to understand; it's unclear whether this is the mechanical addition
> of a parameter before the next patch does shared FlatViews, or whether
> the next patch is mechanical by virtue of this patch doing the
> non-mechanical changes. Maybe:
>
> Mechanical change to add a parameter to make it easier for the next
> patch to share FlatViews.
I was told in this list that "mechanical" is when simple 's/lalala/mememe/'
does the job, when it is bigger than this - then it is "this should not
cause any behavioural change" :) I'll add such note where applicable.
tbh only 1/13, 11/13 and 13/13 do cause a change in behaviour, others do not.
>
>> The first argument of
>> address_space_do_translate() will become a FlatView, however since
>> address_space_get_iotlb_entry() still wants AS, hence this change.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>> ---
>> exec.c | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
--
Alexey
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH qemu v3 11/13] memory: Share FlatView's and dispatch trees between address spaces, (continued)
- [Qemu-devel] [PATCH qemu v3 11/13] memory: Share FlatView's and dispatch trees between address spaces, Alexey Kardashevskiy, 2017/09/18
- [Qemu-devel] [PATCH qemu v3 09/13] memory: Rename mem_begin/mem_commit/mem_add helpers, Alexey Kardashevskiy, 2017/09/18
- [Qemu-devel] [PATCH qemu v3 13/13] memory: Add flat views to HMP "info mtree", Alexey Kardashevskiy, 2017/09/18
- [Qemu-devel] [PATCH qemu v3 08/13] memory: Cleanup after switching to FlatView, Alexey Kardashevskiy, 2017/09/18
- [Qemu-devel] [PATCH qemu v3 07/13] memory: Switch memory from using AddressSpace to FlatView, Alexey Kardashevskiy, 2017/09/18
- [Qemu-devel] [PATCH qemu v3 12/13] memory: Get rid of address_space_init_shareable, Alexey Kardashevskiy, 2017/09/18
- [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export target AS from address_space_translate_internal, Alexey Kardashevskiy, 2017/09/18
- [Qemu-devel] [PATCH qemu v3 05/13] memory: Move AddressSpaceDispatch from AddressSpace to FlatView, Alexey Kardashevskiy, 2017/09/18
- Re: [Qemu-devel] [PATCH qemu v3 00/13] memory: Reduce memory use, no-reply, 2017/09/18
- Re: [Qemu-devel] [PATCH qemu v3 00/13] memory: Reduce memory use, Paolo Bonzini, 2017/09/18