[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED blinker mo
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED blinker model |
Date: |
Wed, 20 Sep 2017 08:55:37 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/19/2017 03:27 PM, Philippe Mathieu-Daudé wrote:
> On 09/19/2017 08:26 AM, Cédric Le Goater wrote:
>> Specs are available here :
>>
>> https://www.nxp.com/docs/en/data-sheet/PCA9552.pdf
>>
>> This is a simple model supporting the basic registers for led and GPIO
>> mode. The device also supports two blinking rates but not the model
>> yet.
>>
>> Signed-off-by: Cédric Le Goater <address@hidden>
>> ---
>> default-configs/arm-softmmu.mak | 1 +
>> hw/misc/Makefile.objs | 1 +
>> hw/misc/pca9552.c | 212
>> ++++++++++++++++++++++++++++++++++++++++
>> include/hw/misc/pca9552.h | 32 ++++++
>
> I'd rather move it to hw/display/
The device is not related to displays. It is just an I2C expander
chip. I would leave it under misc/
C.
>
>> 4 files changed, 246 insertions(+)
>> create mode 100644 hw/misc/pca9552.c
>> create mode 100644 include/hw/misc/pca9552.h
- [Qemu-devel] [PATCH 0/5] aspeed: add a witherspoon-bmc machine, Cédric Le Goater, 2017/09/19
- [Qemu-devel] [PATCH 1/5] aspeed: add support for the witherspoon-bmc board, Cédric Le Goater, 2017/09/19
- [Qemu-devel] [PATCH 2/5] aspeed: add an I2C RTC device to all machines, Cédric Le Goater, 2017/09/19
- [Qemu-devel] [PATCH 3/5] aspeed: Add EEPROM I2C devices, Cédric Le Goater, 2017/09/19
- [Qemu-devel] [PATCH 4/5] misc: add pca9552 LED blinker model, Cédric Le Goater, 2017/09/19
- [Qemu-devel] [PATCH 5/5] aspeed: add the pc9552 chips to the witherspoon machine, Cédric Le Goater, 2017/09/19