Re: [Qemu-devel] [PATCH 2/3] linux-user: add SO_LINGER to setsockopt

[Laurent Vivier]

Le 20/09/2017 à 01:06, Carlo Marcelo Arenas Belón a écrit :
> Original implementation by Chen Gang; all bugs mine
> 
> Signed-off-by: Chen Gang <address@hidden>
> Signed-off-by: Carlo Marcelo Arenas Belón <address@hidden>
> ---
>  linux-user/syscall.c      | 15 +++++++++++++++
>  linux-user/syscall_defs.h |  5 +++++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 9b6364a266..ad689dad50 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -3071,6 +3071,21 @@ set_timeout:
>               unlock_user (dev_ifname, optval_addr, 0);
>               return ret;
>       }
> +        case TARGET_SO_LINGER:
> +        {
> +                struct linger lg;
> +                struct target_linger *tlg;
> +

Why did you remove "optname = SO_LINGER" and "if (optlen !=
sizeof(struct target_linger))"?

Thanks,
Laurent