[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/3] s390x/tcg: add basic MSA features
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/3] s390x/tcg: add basic MSA features |
Date: |
Wed, 20 Sep 2017 11:31:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/20/2017 10:30 AM, David Hildenbrand wrote:
> The STFLE bits for the MSA (extension) facilities simply indicate that
> the respective instructions can be executed. The QUERY subfunction can then
> be used to identify which features exactly are available.
>
> Availability of subfunctions can also vary on real hardware. For now, we
> simply implement a CPU model without any available subfunctions except
> QUERY (which is always around).
>
> As all MSA functions behave quite similarly, we can use one translation
> handler for now. Prepare the code for implementation of actual subfunctions.
>
> At least MSA is helpful for now, as older Linux kernels require this
> facility when compiled for a z9 model. Allow to enable the facilities
> for the qemu cpu model.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/Makefile.objs | 2 +-
> target/s390x/cpu_models.c | 4 +++
> target/s390x/crypto_helper.c | 65
> ++++++++++++++++++++++++++++++++++++++++++++
> target/s390x/helper.h | 1 +
> target/s390x/insn-data.def | 13 +++++++++
> target/s390x/translate.c | 56 ++++++++++++++++++++++++++++++++++++++
> 6 files changed, 140 insertions(+), 1 deletion(-)
> create mode 100644 target/s390x/crypto_helper.c
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions, David Hildenbrand, 2017/09/20
- [Qemu-devel] [PATCH v3 1/3] s390x/tcg: implement spm (SET PROGRAM MASK), David Hildenbrand, 2017/09/20
- [Qemu-devel] [PATCH v3 2/3] s390x/tcg: move wrap_address() to internal.h, David Hildenbrand, 2017/09/20
- [Qemu-devel] [PATCH v3 3/3] s390x/tcg: add basic MSA features, David Hildenbrand, 2017/09/20
- Re: [Qemu-devel] [PATCH v3 3/3] s390x/tcg: add basic MSA features,
Richard Henderson <=
- Re: [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions, Cornelia Huck, 2017/09/21
- Re: [Qemu-devel] [PATCH v3 0/3] Implement basic MSA functions, Cornelia Huck, 2017/09/22