[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transa
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint |
Date: |
Thu, 21 Sep 2017 10:02:02 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 21/09/17 03:14, Paolo Bonzini wrote:
> On 20/09/2017 13:46, Alexey Kardashevskiy wrote:
>> This extends memory_region_transaction_commit() to receive a MR as
>> if it is a root MR or its topmost parent is, then we can only rebuild
>> its FlatView and update it for address spaces sharing it.
>>
>> The optimization gets disabled though if there is full update about to
>> commit.
>>
>> memory_region_set_enabled() is a special case here, it does not use
>> a hint when MR is being disabled.
>>
>> On POWER8 with 255 CPUs, 255 virtio-net, 40 PCI bridges guest this brings
>> down the boot time from 20s to 12s, the total memory footprint
>> goes down (17G -> 8G).
>
> I think this is incorrect if MR has an alias (no matter if enabling or
> disabling)?
Hmmm. Right. I can add a aliases_nr counter to an MR (it does not even have
to go down as aliases are not creared/destroyed often) and take the slow
path if it is not zero, does it make sense?
--
Alexey
- Re: [Qemu-devel] [PATCH qemu v4 09/18] memory: Store physical root MR in FlatView, (continued)
[Qemu-devel] [PATCH qemu v4 14/18] memory: Add flat views to HMP "info mtree", Alexey Kardashevskiy, 2017/09/20
[Qemu-devel] [PATCH qemu v4 07/18] memory: Cleanup after switching to FlatView, Alexey Kardashevskiy, 2017/09/20
[Qemu-devel] [PATCH qemu v4 11/18] memory: Move address_space_update_ioeventfds, Alexey Kardashevskiy, 2017/09/20
[Qemu-devel] [PATCH qemu v4 03/18] memory: Move FlatView allocation to a helper, Alexey Kardashevskiy, 2017/09/20
[Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint, Alexey Kardashevskiy, 2017/09/20
[Qemu-devel] [PATCH qemu v4 16/18] memory: Get rid of address_space_init_shareable, Alexey Kardashevskiy, 2017/09/20
[Qemu-devel] [PATCH qemu v4 05/18] memory: Remove AddressSpace pointer from AddressSpaceDispatch, Alexey Kardashevskiy, 2017/09/20
[Qemu-devel] [PATCH qemu v4 04/18] memory: Move AddressSpaceDispatch from AddressSpace to FlatView, Alexey Kardashevskiy, 2017/09/20