[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] qemu-io: Reset qemuio_blk permissions befor
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/6] qemu-io: Reset qemuio_blk permissions before each command |
|
Date: |
Thu, 21 Sep 2017 15:53:14 +0200 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
Am 15.09.2017 um 12:10 hat Kevin Wolf geschrieben:
> qemu-io provides a 'reopen' command that allows switching from writable
> to read-only access. We need to make sure that we don't try to keep
> write permissions to a BlockBackend that becomes read-only, otherwise
> things are going to fail.
>
> command() already makes sure to request any additional permissions that
> a qemu-io command requires, so just resetting the permissions to values
> that are safe for read-only images is enough to fix this.
>
> As a side effect, this makes the output of qemu-iotests case 187 more
> consistent.
>
> Signed-off-by: Kevin Wolf <address@hidden>
This seems to break qemu-iotests 077 and 081 for raw. I'll look into
it tomorrow.
Kevin
- [Qemu-devel] [PATCH 0/6] block: Fix permissions after ro/rw reopen, Kevin Wolf, 2017/09/15
- [Qemu-devel] [PATCH 1/6] qemu-io: Reset qemuio_blk permissions before each command, Kevin Wolf, 2017/09/15
- [Qemu-devel] [PATCH 3/6] block: Add reopen queue to bdrv_check_perm(), Kevin Wolf, 2017/09/15
- [Qemu-devel] [PATCH 4/6] block: Base permissions on rw state after reopen, Kevin Wolf, 2017/09/15
- [Qemu-devel] [PATCH 2/6] block: Add reopen_queue to bdrv_child_perm(), Kevin Wolf, 2017/09/15
- [Qemu-devel] [PATCH 6/6] block: Fix permissions after bdrv_reopen(), Kevin Wolf, 2017/09/15