[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 07/13] tests: Add FreeBSD image
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v11 07/13] tests: Add FreeBSD image |
Date: |
Fri, 22 Sep 2017 13:31:07 +0800 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, 09/22 00:17, Philippe Mathieu-Daudé wrote:
> Hi Fam,
>
> On 09/21/2017 12:07 PM, Fam Zheng wrote:
> > The image is prepared following instructions as in:
> >
> > https://wiki.qemu.org/Hosts/BSD
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > tests/vm/freebsd | 42 ++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 42 insertions(+)
> > create mode 100755 tests/vm/freebsd
> >
> > diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> > new file mode 100755
> > index 0000000000..039dad8f69
> > --- /dev/null
> > +++ b/tests/vm/freebsd
> > @@ -0,0 +1,42 @@
> > +#!/usr/bin/env python
> > +#
> > +# FreeBSD VM image
> > +#
> > +# Copyright 2017 Red Hat Inc.
> > +#
> > +# Authors:
> > +# Fam Zheng <address@hidden>
> > +#
> > +# This code is licensed under the GPL version 2 or later. See
> > +# the COPYING file in the top-level directory.
> > +#
> > +
> > +import os
> > +import sys
> > +import subprocess
> > +import basevm
> > +
> > +class FreeBSDVM(basevm.BaseVM):
> > + name = "freebsd"
> > + BUILD_SCRIPT = """
> > + set -e;
> > + cd $(mktemp -d /var/tmp/qemu-test.XXXXXX);
> > + tar -xf /dev/vtbd1;
> > + ./configure {configure_opts};
> > + gmake -j{jobs};
> > + gmake check;
> > + """
> > +
> > + def build_image(self, img):
> > + cimg =
> > self._download_with_cache("http://download.patchew.org/freebsd-11.1-amd64.img.xz",
> > +
> > sha256sum='adcb771549b37bc63826c501f05121a206ed3d9f55f49145908f7e1432d65891')
> > + img_tmp_xz = img + ".tmp.xz"
> > + img_tmp = img + ".tmp"
> > + subprocess.check_call(["cp", "-f", cimg, img_tmp_xz])
>
> I'd rather see this part common to 3 images refactored as @static
> BaseVM.download_and_extract_image() and some logging:
>
> logging.debug("Extracting %s...", fname)
>
> > + subprocess.check_call(["xz", "-df", img_tmp_xz])
>
> else one wonder what's happening here.
>
> (for another patch on top on this series)
Yep, that sounds good.
Fam
- Re: [Qemu-devel] [PATCH v11 01/13] gitignore: Ignore vm test images, (continued)
- [Qemu-devel] [PATCH v11 02/13] qemu.py: Add "wait()" method, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 03/13] scripts: Add archive-source.sh, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 04/13] tests: Add a test key pair, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 05/13] tests: Add vm test lib, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 06/13] tests: Add ubuntu.i386 image, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 07/13] tests: Add FreeBSD image, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 08/13] tests: Add NetBSD image, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 09/13] tests: Add OpenBSD image, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 10/13] Makefile: Add rules to run vm tests, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 11/13] MAINTAINERS: Add tests/vm entry, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 12/13] tests: Add README for vm tests, Fam Zheng, 2017/09/21
- [Qemu-devel] [PATCH v11 13/13] docker: Use archive-source.py, Fam Zheng, 2017/09/21