[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] s390x/kvm: fix and cleanup storing CPU statu
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2] s390x/kvm: fix and cleanup storing CPU status |
Date: |
Fri, 22 Sep 2017 09:28:29 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/22/2017 09:03 AM, David Hildenbrand wrote:
> env->psa is a 64bit value, while we copy 4 bytes into the save area,
> resulting always in 0 getting stored.
>
> Let's try to reduce such errors by using a proper structure. While at
> it, use correct cpu->be conversion (and get_psw_mask()), as we will be
> reusing this code for TCG soon.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>
> v1 -> v2:
> - dropped QEMU_PACKED
> - Moved QEMU_BUILD_BUG_ON()
> - Retested if it works now
>
> target/s390x/kvm.c | 62
> ++++++++++++++++++++++++++++++++++++------------------
> 1 file changed, 42 insertions(+), 20 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~