[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2/6] plugin: add initial plugin support
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [RFC 2/6] plugin: add initial plugin support |
Date: |
Tue, 26 Sep 2017 06:27:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 06.09.2017 22:28, Emilio G. Cota wrote:
[...]
> diff --git a/plugin.c b/plugin.c
> new file mode 100644
> index 0000000..3cd19df
> --- /dev/null
> +++ b/plugin.c
> @@ -0,0 +1,519 @@
> +/* plugin.c - QEMU Plugin interface
> + *
> + * Copyright (C) 2017, Emilio G. Cota <address@hidden>
> + *
> + * License: GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
If you introduce new .c files, please add some sentences with a proper
description in the header with some very high level description about
what the code in the file is supposed to be doing. Just reading "plugin
interface" is not really very helpful when trying to understand new code.
Thanks,
Thomas
- [Qemu-devel] [RFC 0/6] initial plugin support, Emilio G. Cota, 2017/09/06
- [Qemu-devel] [RFC 6/6] linux-user: support -plugin option, Emilio G. Cota, 2017/09/06
- [Qemu-devel] [RFC 3/6] configure: add --enable-plugins, Emilio G. Cota, 2017/09/06
- [Qemu-devel] [RFC 4/6] Makefile: install qemu-api.h as include/qemu-plugin.h, Emilio G. Cota, 2017/09/06
- [Qemu-devel] [RFC 5/6] vl: support -plugin option, Emilio G. Cota, 2017/09/06
- [Qemu-devel] [RFC 1/6] tcg: keep a pointer to the current TB in TCGContext, Emilio G. Cota, 2017/09/06
- [Qemu-devel] [RFC 2/6] plugin: add initial plugin support, Emilio G. Cota, 2017/09/06
- Re: [Qemu-devel] [RFC 0/6] initial plugin support, Peter Maydell, 2017/09/14
- Re: [Qemu-devel] [RFC 0/6] initial plugin support, Stefan Hajnoczi, 2017/09/18
- Re: [Qemu-devel] [RFC 0/6] initial plugin support, Thomas Huth, 2017/09/26