Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of next_core_id

[Igor Mammedov]

On Mon, 25 Sep 2017 16:14:16 -0700
Richard Henderson <address@hidden> wrote:

> On 09/18/2017 08:59 AM, David Hildenbrand wrote:
> >      /* sync cs->cpu_index and env->core_id. The latter is needed for TCG. 
> > */
> > -    cs->cpu_index = env->core_id;
> > +    cs->cpu_index = cpu->env.core_id;
> > +#endif  
> 
> Any reason not to drop core_id entirely in favour of cpu_index?
> (Since cpu_index itself is generic and can't be dropped.)
I prefer core_id vs cpu_index as the later is too generic
(and we were trying to decouple target specific attributes
/coreid/cpuid/whatnot from cpu_index as much as possible
so it would be more clear what they mean and if possible
make them in-depended of QEMU internal cpu_index which is
essentially not owned by target).