[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/4] qom: provide root container for internal
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/4] qom: provide root container for internal objs |
Date: |
Tue, 26 Sep 2017 16:49:28 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, Sep 26, 2017 at 09:46:16AM +0100, Stefan Hajnoczi wrote:
> On Tue, Sep 26, 2017 at 12:52:09PM +0800, Peter Xu wrote:
> > diff --git a/include/qom/object.h b/include/qom/object.h
> > index f3e5cff..f567052 100644
> > --- a/include/qom/object.h
> > +++ b/include/qom/object.h
> > @@ -1214,6 +1214,16 @@ Object *object_get_root(void);
> > Object *object_get_objects_root(void);
> >
> > /**
> > + * object_get_internal_root:
> > + *
> > + * Get the container object that holds internally used object
> > + * instances. This is the object at path "/internal-objects"
>
> When you update the comment, please mention that this root is for
> objects that must not be user-visible. This root is not exposed in the
> qom tree.
>
> I think mentioning this will help others understand the purpose of the
> internal root.
Sure. Will do.
--
Peter Xu