[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks |
Date: |
Tue, 26 Sep 2017 11:02:36 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Sat, Sep 23, 2017 at 02:14:08PM +0300, Manos Pitsidianakis wrote:
> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new
> bdrv_co_drain_end callback to match bdrv_drained_begin/end and
> drained_begin/end of BdrvChild. This is needed because the throttle driver
> (block/throttle.c) needs a way to mark the end of the drain in order to
> toggle
> io_limits_disabled correctly.
>
> Based-on: <address@hidden>
> "block/throttle-groups.c: allocate RestartData on the heap"
> Which fixes a coroutine crash in block/throttle-groups.c
>
> v3:
> fixed commit message typo in first patch [Fam]
> rephrased doc comment based on mailing discussion
> v2:
> add doc for callbacks and change order of request polling for completion
> [Stefan]
>
> Manos Pitsidianakis (3):
> block: add bdrv_co_drain_end callback
> block: rename bdrv_co_drain to bdrv_co_drain_begin
> block/throttle.c: add bdrv_co_drain_begin/end callbacks
>
> include/block/block_int.h | 13 ++++++++++---
> block/io.c | 48
> +++++++++++++++++++++++++++++++++--------------
> block/qed.c | 6 +++---
> block/throttle.c | 18 ++++++++++++++++++
> 4 files changed, 65 insertions(+), 20 deletions(-)
>
> --
> 2.11.0
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan