[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 4/6] ui: convert common input code to keycode
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 4/6] ui: convert common input code to keycodemapdb |
Date: |
Thu, 28 Sep 2017 13:25:47 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/28/2017 07:06 AM, Daniel P. Berrange wrote:
> Replace the number_to_qcode, qcode_to_number and linux_to_qcode
> tables with automatically generated tables.
>
> Missing entries in linux_to_qcode now fixed:
>
> KEY_LINEFEED -> Q_KEY_CODE_LF
> KEY_KPEQUAL -> Q_KEY_CODE_KP_EQUALS
> KEY_COMPOSE -> Q_KEY_CODE_COMPOSE
> KEY_AGAIN -> Q_KEY_CODE_AGAIN
> KEY_PROPS -> Q_KEY_CODE_PROPS
> KEY_UNDO -> Q_KEY_CODE_UNDO
> KEY_FRONT -> Q_KEY_CODE_FRONT
> KEY_COPY -> Q_KEY_CODE_COPY
> KEY_OPEN -> Q_KEY_CODE_OPEN
> KEY_PASTE -> Q_KEY_CODE_PASTE
> KEY_CUT -> Q_KEY_CODE_CUT
> KEY_HELP -> Q_KEY_CODE_HELP
> KEY_MEDIA -> Q_KEY_CODE_MEDIASELECT
>
> In additionsome fixes:
s/additionsome/addition, some/
>
> - KEY_PLAYPAUSE now maps to Q_KEY_CODE_AUDIOPLAY, instead of
> KEY_PLAYCD. KEY_PLAYPAUSE is defined across almost all scancodes
> sets, while KEY_PLAYCD only appears in AT set1, so the former is
> a more useful mapping.
>
> Missing entries in qcode_to_number now fixed:
>
> Q_KEY_CODE_AGAIN -> 0x85
> Q_KEY_CODE_PROPS -> 0x86
> Q_KEY_CODE_UNDO -> 0x87
> Q_KEY_CODE_FRONT -> 0x8c
> Q_KEY_CODE_COPY -> 0xf8
> Q_KEY_CODE_OPEN -> 0x64
> Q_KEY_CODE_PASTE -> 0x65
> Q_KEY_CODE_CUT -> 0xbc
> Q_KEY_CODE_LF -> 0x5b
> Q_KEY_CODE_HELP -> 0xf5
> Q_KEY_CODE_COMPOSE -> 0xdd
> Q_KEY_CODE_KP_EQUALS -> 0x59
> Q_KEY_CODE_MEDIASELECT -> 0xed
>
> In addition some fixes:
Hmm - inconsistent with my suggestion above with regards to comma usage;
I think this is one scenario in English where you can get away without
the comma, even though I would use it.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v7 1/6] build: automatically handle GIT submodule checkout for dtc, (continued)
- [Qemu-devel] [PATCH v7 2/6] docker: don't rely on submodules existing in the main checkout, Daniel P. Berrange, 2017/09/28
- [Qemu-devel] [PATCH v7 3/6] ui: add keycodemapdb repository as a GIT submodule, Daniel P. Berrange, 2017/09/28
- [Qemu-devel] [PATCH v7 5/6] ui: convert key events to QKeyCodes immediately, Daniel P. Berrange, 2017/09/28
- [Qemu-devel] [PATCH v7 6/6] ui: don't export qemu_input_event_new_key, Daniel P. Berrange, 2017/09/28
- [Qemu-devel] [PATCH v7 4/6] ui: convert common input code to keycodemapdb, Daniel P. Berrange, 2017/09/28
- Re: [Qemu-devel] [PATCH v7 4/6] ui: convert common input code to keycodemapdb,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule, no-reply, 2017/09/28
- [Qemu-devel] [PATCH v7 0/6] Initial support for keycodemapdb GIT submodule, Programmingkid, 2017/09/28