[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/mips: remove commented out codes in tran
|
From: |
Yongbok Kim |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/mips: remove commented out codes in translate.c |
|
Date: |
Fri, 29 Sep 2017 11:14:25 +0100 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 29/09/2017 10:58, Philippe Mathieu-Daudé wrote:
> Hi Jiang,
>
> I'm not sure it is really helpful to remove those comment, they are here as
> debt to the project, reminding what should be implemented.
>
> Are you proposing to accept this instructions will never get implemented?
>
> Regards,
>
> Phil.
>
Hi Phil,
The commented codes are all trivial. When the time we implement those
features it is merely copy & paste from the specification. I don't think
there is much harm to remove the comments.
Besides there is TODO file in the same directory but that has not been
updated for a while, perhaps updating the file is much relevant with this
patch.
Regards,
Yongbok