[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 19/23] qemu-img: Change img_rebase() to be by
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v4 19/23] qemu-img: Change img_rebase() to be byte-based |
Date: |
Fri, 29 Sep 2017 15:38:18 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/13/2017 12:03 PM, Eric Blake wrote:
> In the continuing quest to make more things byte-based, change
> the internal iteration of img_rebase(). We can finally drop the
> TODO assertion added earlier, now that the entire algorithm is
> byte-based and no longer has to shift from bytes to sectors.
>
> Most of the change is mechanical ('num_sectors' becomes 'size',
> 'sector' becomes 'offset', 'n' goes from sectors to bytes); some
> of it is also a cleanup (use of MIN() instead of open-coding,
> loss of variable 'count' added earlier in commit d6a644bb).
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: John Snow <address@hidden>
- Re: [Qemu-devel] [PATCH v4 13/23] qemu-img: Simplify logic in img_compare(), (continued)
- [Qemu-devel] [PATCH v4 17/23] qemu-img: Change check_empty_sectors() to byte-based, Eric Blake, 2017/09/13
- [Qemu-devel] [PATCH v4 18/23] qemu-img: Change compare_sectors() to be byte-based, Eric Blake, 2017/09/13
- [Qemu-devel] [PATCH v4 19/23] qemu-img: Change img_rebase() to be byte-based, Eric Blake, 2017/09/13
- Re: [Qemu-devel] [PATCH v4 19/23] qemu-img: Change img_rebase() to be byte-based,
John Snow <=
- [Qemu-devel] [PATCH v4 20/23] qemu-img: Change img_compare() to be byte-based, Eric Blake, 2017/09/13
- [Qemu-devel] [PATCH v4 21/23] block: Align block status requests, Eric Blake, 2017/09/13
- [Qemu-devel] [PATCH v4 22/23] block: Relax bdrv_aligned_preadv() assertion, Eric Blake, 2017/09/13
- [Qemu-devel] [PATCH v4 23/23] qemu-io: Relax 'alloc' now that block-status doesn't assert, Eric Blake, 2017/09/13
- Re: [Qemu-devel] [PATCH v4 00/23] make bdrv_get_block_status byte-based, Eric Blake, 2017/09/13