Re: [Qemu-devel] [PATCH v4 4/9] disas: Support the Capstone disassembler library

[Philippe Mathieu-Daudé]

On 10/02/2017 03:34 PM, Richard Henderson wrote:
> On 10/02/2017 09:36 AM, Philippe Mathieu-Daudé wrote:
> > Maybe some defines like:
> >
> > #define LARGEST_TARGET_INSTR_SIZE 32
> >
> > #define MINIMUM_TARGET_PAGE_SIZE 1024
>
> Eh.  If I weren't simply pulling numbers out of my hat, perhaps.
> Does it really make things clearer beyond sizeof or a great big comment?

big comment is great!