[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/xlnx-zynqmp: Mark the "xlnx, zynqmp" dev
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/xlnx-zynqmp: Mark the "xlnx, zynqmp" device with user_creatable = false |
Date: |
Tue, 3 Oct 2017 14:49:16 +0100 |
On 26 September 2017 at 16:51, Thomas Huth <address@hidden> wrote:
> The device uses serial_hds in its realize function and thus can't be
> used twice. Apart from that, the comma in its name makes it quite hard
> to use for the user anyway, since a comma is normally used to separate
> the device name from its properties when using the "-device" parameter
> or the "device_add" HMP command.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> hw/arm/xlnx-zynqmp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c
> index 2b27daf..d4b6560 100644
> --- a/hw/arm/xlnx-zynqmp.c
> +++ b/hw/arm/xlnx-zynqmp.c
> @@ -440,6 +440,8 @@ static void xlnx_zynqmp_class_init(ObjectClass *oc, void
> *data)
>
> dc->props = xlnx_zynqmp_props;
> dc->realize = xlnx_zynqmp_realize;
> + /* Reason: Uses serial_hds in realize function, thus can't be used twice
> */
> + dc->user_creatable = false;
> }
>
> static const TypeInfo xlnx_zynqmp_type_info = {
Applied to target-arm.next, thanks.
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH] hw/arm/xlnx-zynqmp: Mark the "xlnx, zynqmp" device with user_creatable = false,
Peter Maydell <=