[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/11] qapi2texi: Clean up texi_sections()
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 06/11] qapi2texi: Clean up texi_sections() |
Date: |
Wed, 4 Oct 2017 12:24:59 +0200 |
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster <address@hidden> wrote:
> Repurposing the function parameter doc for stepping through
> doc.sections.__str__() is not nice. Use new variable @text instead.
>
> While there, eliminate variables name and func.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
> ---
> scripts/qapi2texi.py | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py
> index a317526e51..f876d9a174 100755
> --- a/scripts/qapi2texi.py
> +++ b/scripts/qapi2texi.py
> @@ -180,16 +180,14 @@ def texi_sections(doc):
> """Format additional sections following arguments"""
> body = ''
> for section in doc.sections:
> - name, doc = (section.name, str(section))
> - func = texi_format
> - if name.startswith('Example'):
> - func = texi_example
> -
> - if name:
> + if section.name:
> # prefer @b over @strong, so txt doesn't translate it to *Foo:*
> - body += 'address@hidden:}\n' % name
> -
> - body += func(doc)
> + body += 'address@hidden:}\n' % section.name
> + text = str(section)
> + if section.name.startswith('Example'):
> + body += texi_example(text)
> + else:
> + body += texi_format(text)
> return body
>
>
> --
> 2.13.6
>
>
--
Marc-André Lureau
- [Qemu-devel] [PATCH 07/11] qapi: Unify representation of doc section without name, (continued)
- [Qemu-devel] [PATCH 07/11] qapi: Unify representation of doc section without name, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 02/11] qapi: Stop rejecting #optional, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 03/11] qapi: Eliminate QAPISchemaParser.__init__()'s local fname, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 05/11] tests/qapi-schema/doc-bad-section: New, factored out of doc-good, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 06/11] qapi2texi: Clean up texi_sections(), Markus Armbruster, 2017/10/02
- Re: [Qemu-devel] [PATCH 06/11] qapi2texi: Clean up texi_sections(),
Marc-André Lureau <=
- [Qemu-devel] [PATCH 10/11] qapi: Rename QAPIDoc.parser, .section to ._parser, ._section, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 01/11] qapi-schema: Fix query-vm-generation-id's doc comment markup, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 11/11] qapi2texi: De-duplicate code to add blank line before symbol, Markus Armbruster, 2017/10/02
- [Qemu-devel] [PATCH 08/11] qapi: Simplify representation of QAPIDoc section text, Markus Armbruster, 2017/10/02