Re: [Qemu-devel] [PATCH v2 29/30] s390x/tcg: refactor stfl(e) to use s390_get_feat_block()

[Richard Henderson]

On 09/28/2017 04:37 PM, David Hildenbrand wrote:
> Refactor it to use s390_get_feat_block(). Directly write into the mapped
> lowcore with stfl and make sure it is really only compiled if needed.
> 
> While at it, add an alignment check for STFLE and avoid
> potential_page_fault() by properly restoring the CPU state.
> 
> Due to s390_get_feat_block(), we will now also indicate the
> "Configuration-z-architectural-mode", which is with new SIGP code the
> right thing to do.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
>  target/s390x/misc_helper.c | 67 
> ++++++++++++++++++++--------------------------
>  target/s390x/translate.c   |  1 -
>  2 files changed, 29 insertions(+), 39 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~