[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 88/88] scripts/coverity-model: use g_new() famil
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 88/88] scripts/coverity-model: use g_new() family of functions |
Date: |
Mon, 09 Oct 2017 08:46:57 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Please cc me on changes to stuff I maintain, as scripts/get_maintainer
tells you :)
Philippe Mathieu-Daudé <address@hidden> writes:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/coverity-model.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
> index c702804f41..de07bffb57 100644
> --- a/scripts/coverity-model.c
> +++ b/scripts/coverity-model.c
> @@ -363,7 +363,7 @@ int g_poll (GPollFD *fds, unsigned nfds, int timeout)
> typedef struct _GIOChannel GIOChannel;
> GIOChannel *g_io_channel_unix_new(int fd)
> {
> - GIOChannel *c = g_malloc0(sizeof(GIOChannel));
> + GIOChannel *c = g_new0(GIOChannel, 1);
> __coverity_escape__(fd);
> return c;
> }
Hmm.
The Coverity model carefully explains g_malloc0(). It doesn't explain
g_new0(). With any luck, Coverity can see through g_new0() --- it's a
macro in my <gmem.h>. But why complicate matters? The normal reason
for changing g_malloc0() to g_new0() doesn't apply here. Let's leave
the model alone.
- [Qemu-devel] [PATCH 80/88] numa: use g_new() family of functions, (continued)
- [Qemu-devel] [PATCH 80/88] numa: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-devel] [PATCH 81/88] hw/acpi: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-devel] [PATCH 82/88] hw/ipmi: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-devel] [PATCH 83/88] hw/pci: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-devel] [PATCH 84/88] hw/scsi: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-devel] [PATCH 85/88] hw/usb: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-devel] [PATCH 86/88] net/hub: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-devel] [PATCH 87/88] hw/net/rocker: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- [Qemu-devel] [PATCH 88/88] scripts/coverity-model: use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- Re: [Qemu-devel] [PATCH 88/88] scripts/coverity-model: use g_new() family of functions,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH 00/88] use g_new() family of functions, Philippe Mathieu-Daudé, 2017/10/06
- Re: [Qemu-devel] [PATCH 00/88] use g_new() family of functions, no-reply, 2017/10/06
- Re: [Qemu-devel] [PATCH 00/88] use g_new() family of functions, no-reply, 2017/10/07
- Re: [Qemu-devel] [PATCH 00/88] use g_new() family of functions, Peter Maydell, 2017/10/07