Re: [Qemu-devel] [PATCH v2 26/30] s390x/tcg: switch to new SIGP handling code

[Cornelia Huck]

On Fri, 6 Oct 2017 10:02:43 -0400
Richard Henderson <address@hidden> wrote:

> On 09/28/2017 04:37 PM, David Hildenbrand wrote:
> >  static ExitStatus op_sigp(DisasContext *s, DisasOps *o)
> >  {
> >      TCGv_i32 r1 = tcg_const_i32(get_field(s->fields, r1));
> > +    TCGv_i32 r3 = tcg_const_i32(get_field(s->fields, r3));
> >      check_privileged(s);
> > -    potential_page_fault(s);
> > -    gen_helper_sigp(cc_op, cpu_env, o->in2, r1, o->in1);
> > +    gen_helper_sigp(cc_op, cpu_env, o->in2, r1, r3);
> >      set_cc_static(s);
> >      tcg_temp_free_i32(r1);
> > +    tcg_temp_free_i32(r3);
> >      return NO_EXIT;
> >  }  
> 
> You want to change insn-data.def as well.
> 
> -    C(0xae00, SIGP,    RS_a,  Z,   r3_o, a2, 0, 0, sigp, 0)
> +    C(0xae00, SIGP,    RS_a,  Z,   0, a2, 0, 0, sigp, 0)

I'll do that while applying. Let's avoid another patchbomb :)

> 
> Otherwise,
> Reviewed-by: Richard Henderson <address@hidden>
> 
> 
> r~