qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 8/9] target/arm: Support some Thumb insns being


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 8/9] target/arm: Support some Thumb insns being always unconditional
Date: Wed, 11 Oct 2017 10:57:42 +0100

On 11 October 2017 at 03:52, Richard Henderson
<address@hidden> wrote:
> On 10/09/2017 06:48 AM, Peter Maydell wrote:
>> -    if (dc->condexec_mask) {
>> +    if (dc->condexec_mask && !thumb_insn_is_unconditional(dc, insn)) {
>>          uint32_t cond = dc->condexec_cond;
>>
>>          if (cond != 0x0e) {     /* Skip conditional when condition is AL. */
>
> Don't you still need to advance the condexec_mask?

Yes -- that happens after we've called disas_thumb{,2}_insn()
in thumb_tr_translate_insn().

This patch just makes always-unconditional insns behave
as if the condition is AL.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]