[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/7] io: pass a struct iovec into qio_channel
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/7] io: pass a struct iovec into qio_channel_websock_encode |
Date: |
Wed, 11 Oct 2017 07:30:45 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/11/2017 05:09 AM, Daniel P. Berrange wrote:
> Instead of requiring use of another Buffer, pass a struct iovec
> into qio_channel_websock_encode, which gives callers more
> flexibility in how they process data.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> +static void qio_channel_websock_encode(QIOChannelWebsock *ioc,
> + uint8_t opcode,
> + const struct iovec *iov,
> + size_t niov,
> + size_t size)
> {
> size_t header_size;
> + size_t i;
> union {
> char buf[QIO_CHANNEL_WEBSOCK_HEADER_LEN_64_BIT];
> QIOChannelWebsockHeader ws;
Is it worth adding assert(size <= iov_size(iov, niov)) near the top,
> + trace_qio_channel_websock_encode(ioc, opcode, header_size, size);
> + buffer_reserve(&ioc->encoutput, header_size + size);
> + buffer_append(&ioc->encoutput, header.buf, header_size);
> + for (i = 0; i < niov && size != 0; i++) {
> + size_t want = iov[i].iov_len;
> + if (want > size) {
> + want = size;
> + }
> + buffer_append(&ioc->encoutput, iov[i].iov_base, want);
> + size -= want;
> + }
so we don't have to worry about a huge size causing us to buffer_reserve
far too much space?
Doesn't affect my R-b, though.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/7] Limit websockets memory usage & other bug fixes, Daniel P. Berrange, 2017/10/11
- [Qemu-devel] [PATCH v2 2/7] io: simplify websocket ping reply handling, Daniel P. Berrange, 2017/10/11
- [Qemu-devel] [PATCH v2 1/7] io: monitor encoutput buffer size from websocket GSource, Daniel P. Berrange, 2017/10/11
- [Qemu-devel] [PATCH v2 5/7] io: get rid of bounce buffering in websock write path, Daniel P. Berrange, 2017/10/11
- [Qemu-devel] [PATCH v2 7/7] io: add trace points for websocket HTTP protocol headers, Daniel P. Berrange, 2017/10/11
- [Qemu-devel] [PATCH v2 6/7] io: cope with websock 'Connection' header having multiple values, Daniel P. Berrange, 2017/10/11
- [Qemu-devel] [PATCH v2 4/7] io: pass a struct iovec into qio_channel_websock_encode, Daniel P. Berrange, 2017/10/11
- [Qemu-devel] [PATCH v2 3/7] io: get rid of qio_channel_websock_encode helper method, Daniel P. Berrange, 2017/10/11