[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply h
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending |
Date: |
Thu, 12 Oct 2017 16:52:53 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote:
> Use packed structure instead of pointer arithmetics.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> include/block/nbd.h | 6 ++++++
> nbd/server.c | 36 ++++++++++++++----------------------
> 2 files changed, 20 insertions(+), 22 deletions(-)
>
> if (!len) {
> - ret = nbd_send_reply(client->ioc, reply, errp);
> + ret = nbd_write(client->ioc, &simple_reply, sizeof(simple_reply),
> NULL);
> } else {
> qio_channel_set_cork(client->ioc, true);
> - ret = nbd_send_reply(client->ioc, reply, errp);
> + ret = nbd_write(client->ioc, &simple_reply, sizeof(simple_reply),
> NULL);
One more thing: this should be errp, not NULL - we don't want to lose
the error, even if the next patch changes things yet again.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 13/13] nbd: Minimal structured read for client, (continued)
- [Qemu-devel] [PATCH v3 13/13] nbd: Minimal structured read for client, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-devel] [PATCH v3 09/13] nbd: Minimal structured read for server, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-devel] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-devel] [PATCH v3 07/13] nbd-server: simplify reply transmission, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-devel] [PATCH v3 01/13] block/nbd-client: assert qiov len once in nbd_co_request, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-devel] [PATCH v3 06/13] nbd/server: refactor nbd_co_send_simple_reply parameters, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-devel] [PATCH v3 08/13] nbd: header constants indenting, Vladimir Sementsov-Ogievskiy, 2017/10/12
- Re: [Qemu-devel] [PATCH v3 00/13] nbd minimal structured read, no-reply, 2017/10/12
- Re: [Qemu-devel] [PATCH v3 00/13] nbd minimal structured read, Eric Blake, 2017/10/12