[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] netduino2: Specify the valid CPUs
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] netduino2: Specify the valid CPUs |
Date: |
Fri, 13 Oct 2017 11:00:04 +0200 |
On Thu, 12 Oct 2017 17:07:25 -0700
Alistair Francis <address@hidden> wrote:
> List all possible valid CPU options.
>
> Although the board only ever has a Cortex-M3 we mark the Cortex-M4 as
> supported because the Netduino2 Plus supports the Cortex-M4 and the
> Netduino2 Plus is similar to the Netduino2.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Reviewed-by: Eduardo Habkost <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>
> V2:
> - Fixup allignment
> RFC v2:
> - Use a NULL terminated list
> - Add the Cortex-M4 for testing
>
>
> hw/arm/netduino2.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c
> index f936017d4a..6427552a72 100644
> --- a/hw/arm/netduino2.c
> +++ b/hw/arm/netduino2.c
> @@ -34,18 +34,26 @@ static void netduino2_init(MachineState *machine)
> DeviceState *dev;
>
> dev = qdev_create(NULL, TYPE_STM32F205_SOC);
> - qdev_prop_set_string(dev, "cpu-type", ARM_CPU_TYPE_NAME("cortex-m3"));
> + qdev_prop_set_string(dev, "cpu-type", machine->cpu_type);
> object_property_set_bool(OBJECT(dev), true, "realized", &error_fatal);
>
> armv7m_load_kernel(ARM_CPU(first_cpu), machine->kernel_filename,
> FLASH_SIZE);
> }
>
> +const char *netduino_valid_cpus[] = {
may be add 'static' here and ditto in other patches
> + ARM_CPU_TYPE_NAME("cortex-m3"),
> + ARM_CPU_TYPE_NAME("cortex-m4"),
> + NULL
> + };
> +
> static void netduino2_machine_init(MachineClass *mc)
> {
> mc->desc = "Netduino 2 Machine";
> mc->init = netduino2_init;
> mc->ignore_memory_transaction_failures = true;
> + mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-m3");
> + mc->valid_cpu_types = netduino_valid_cpus;
> }
>
> DEFINE_MACHINE("netduino2", netduino2_machine_init)
- [Qemu-devel] [PATCH v2 0/5] Add a valid_cpu_types property, Alistair Francis, 2017/10/12
- [Qemu-devel] [PATCH v2 3/5] raspi: Specify the valid CPUs, Alistair Francis, 2017/10/12
- [Qemu-devel] [PATCH v2 2/5] bcm2836: Use the Cortex-A7 instead of Cortex-A15, Alistair Francis, 2017/10/12
- [Qemu-devel] [PATCH v2 1/5] netduino2: Specify the valid CPUs, Alistair Francis, 2017/10/12
- Re: [Qemu-devel] [PATCH v2 1/5] netduino2: Specify the valid CPUs,
Igor Mammedov <=
- [Qemu-devel] [PATCH v2 5/5] xilinx_zynq: : Specify the valid CPUs, Alistair Francis, 2017/10/12
- [Qemu-devel] [PATCH v2 4/5] xlnx-zcu102: Specify the valid CPUs, Alistair Francis, 2017/10/12
- Re: [Qemu-devel] [PATCH v2 0/5] Add a valid_cpu_types property, Igor Mammedov, 2017/10/13