[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure |
Date: |
Fri, 13 Oct 2017 16:16:54 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote:
> This patch factors out code to use the ThrottleLimits
> structure.
> { 'struct': 'BlockIOThrottle',
> - 'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd': 'int',
> - 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int', 'iops_wr':
> 'int',
> - '*bps_max': 'int', '*bps_rd_max': 'int',
> - '*bps_wr_max': 'int', '*iops_max': 'int',
> - '*iops_rd_max': 'int', '*iops_wr_max': 'int',
> - '*bps_max_length': 'int', '*bps_rd_max_length': 'int',
> - '*bps_wr_max_length': 'int', '*iops_max_length': 'int',
> - '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',
> - '*iops_size': 'int', '*group': 'str' } }
> + 'base': 'ThrottleLimits',
> + 'data': { '*device': 'str', '*id': 'str', '*group': 'str' } }
So BlockIOThrottle used to have parameters named bps_rd and iops_wr, and
after this patch they become bps-read and iops-write. This breaks the
API completely, as you can see if you run e.g. iotest 129:
AssertionError: failed path traversal for "return" in "{u'error': {u'class':
u'GenericError', u'desc': u"Parameter 'iops_rd' is unexpected"}}"
I just checked previous versions of the series and I see that Manos
already warned you of this in v11:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg04698.html
Berto
- [Qemu-devel] [PATCH v13 0/6] fsdev: qmp interface for io throttling, Pradeep Jagadeesh, 2017/10/02
- [Qemu-devel] [PATCH v13 1/6] throttle: factor out duplicate code, Pradeep Jagadeesh, 2017/10/02
- [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code, Pradeep Jagadeesh, 2017/10/02
- [Qemu-devel] [PATCH v13 6/6] fsdev: hmp interface for throttling, Pradeep Jagadeesh, 2017/10/02
- [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure, Pradeep Jagadeesh, 2017/10/02
- Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure,
Alberto Garcia <=
- [Qemu-devel] [PATCH v13 4/6] hmp: create a throttle initialization function for code reuse, Pradeep Jagadeesh, 2017/10/02
- [Qemu-devel] [PATCH v13 5/6] fsdev: QMP interface for throttling, Pradeep Jagadeesh, 2017/10/02
- Re: [Qemu-devel] [PATCH v13 0/6] fsdev: qmp interface for io throttling, no-reply, 2017/10/02