Re: [Qemu-devel] [RFC PATCH 00/30] v8.2 half-precision support (work-in-

qemu-devel
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 00/30] v8.2 half-precision support (work-in-

From:	no-reply
Subject:	Re: [Qemu-devel] [RFC PATCH 00/30] v8.2 half-precision support (work-in-progress)
Date:	Fri, 13 Oct 2017 09:59:27 -0700 (PDT)
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH 00/30] v8.2 half-precision support 
(work-in-progress)

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a8d9e2a127 target/arm/translate-a64.c: add FP16 FCVTPS to 2 reg misc
e47972bdb3 tests/test-softfloat: add f16_to_int16 conversion test
a60d18c62d softfloat: float16_to_int16 conversion
bfdf06e71c target/arm/translate-a64.c: add FP16 FRINTP to 2 reg misc
9743fd4234 tests/test-softfloat: add a simple test framework
c00f720eaa softfloat: float16_round_to_int
210fa92599 disas_simd_indexed: support half-precision operations
1ad1d7e5a4 softfloat: add float16_rem and float16_muladd (!CHECK)
13cc912be0 target/arm/translate-a64.c: add FP16 FAGCT to AdvSIMD 3 Same
eae9498170 target/arm/translate-a64: add FP16 2-reg misc compare (zero)
3bd8bfc5fa softfloat: half-precision compare functions
6d48002215 Fix mask for AdvancedSIMD 2 reg misc
e2560b1cc1 target/arm/translate-a64.c: add AdvSIMD scalar two-reg misc skeleton
fd8d37dc6b target/arm/translate-a64.c: add FP16 FMULX
023a4abddd target/arm/translate-a64.c: add FP16 FADD/FMUL/FDIV to AdvSIMD 3 
Same (!sub)
a484840d45 softfloat: half-precision add/sub/mul/div support
e708f32268 softfloat: 16 bit helpers for shr, clz and rounding and packing
2f65402d6d target/arm/translate-a64.c: AdvSIMD scalar 3 Same FP16 initial decode
76387c084b target/arm/translate-a64.c: handle_3same_64 comment fix
4b10ff1a59 target/arm: implement half-precision F(MIN|MAX)(V|NMV)
ebbf91f0d9 softfloat: improve comments on ARM NaN propagation
c69770519b softfloat: propagate signalling NaNs in MINMAX
beeb3d9188 softfloat: add half-precision expansions for MINMAX fns
8db446be24 fpu/softfloat: implement float16_abs helper
97b4ec2f26 fpu/softfloat: implement float16_squash_input_denormal
fcac6b5acb softfloat: implement propagateFloat16NaN
cc5f898f35 target/arm/cpu.h: update comment for half-precision values
a3fa9b0170 include/exec/helper-head.h: support f16 in helper calls
a37d42107d arm: introduce ARM_V8_FP16 feature bit
e8c0401452 linux-user/main: support dfilter

=== OUTPUT BEGIN ===
Checking PATCH 1/30: linux-user/main: support dfilter...
ERROR: space required after that ',' (ctx:VxV)
#33: FILE: linux-user/main.c:4063:
+     "range[,...]","filter logging based on address range"},
                   ^

total: 1 errors, 0 warnings, 19 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/30: arm: introduce ARM_V8_FP16 feature bit...
Checking PATCH 3/30: include/exec/helper-head.h: support f16 in helper calls...
Checking PATCH 4/30: target/arm/cpu.h: update comment for half-precision 
values...
Checking PATCH 5/30: softfloat: implement propagateFloat16NaN...
Checking PATCH 6/30: fpu/softfloat: implement float16_squash_input_denormal...
Checking PATCH 7/30: fpu/softfloat: implement float16_abs helper...
Checking PATCH 8/30: softfloat: add half-precision expansions for MINMAX fns...
Checking PATCH 9/30: softfloat: propagate signalling NaNs in MINMAX...
Checking PATCH 10/30: softfloat: improve comments on ARM NaN propagation...
WARNING: line over 80 characters
#29: FILE: fpu/softfloat-specialize.h:450:
+    /* ARM mandated NaN propagation rules (see FPProcessNaNs()), take the 
first of:

total: 0 errors, 1 warnings, 19 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/30: target/arm: implement half-precision F(MIN|MAX)(V|NMV)...
ERROR: space required before the open parenthesis '('
#126: FILE: target/arm/translate-a64.c:5646:
+        switch(fpopcode) {

WARNING: line over 80 characters
#152: FILE: target/arm/translate-a64.c:5672:
+            fprintf(stderr, "%s: fpopcode %x not handled\n", __func__, 
fpopcode);

total: 1 errors, 1 warnings, 208 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 12/30: target/arm/translate-a64.c: handle_3same_64 comment fix...
Checking PATCH 13/30: target/arm/translate-a64.c: AdvSIMD scalar 3 Same FP16 
initial decode...
WARNING: line over 80 characters
#82: FILE: target/arm/translate-a64.c:9810:
+            fprintf(stderr,"%s: insn %#04x fpop %#2x\n", __func__, insn, 
fpopcode);

ERROR: space required after that ',' (ctx:VxV)
#82: FILE: target/arm/translate-a64.c:9810:
+            fprintf(stderr,"%s: insn %#04x fpop %#2x\n", __func__, insn, 
fpopcode);
                           ^

total: 1 errors, 1 warnings, 88 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 14/30: softfloat: 16 bit helpers for shr, clz and rounding and 
packing...
ERROR: space prohibited after that open parenthesis '('
#38: FILE: fpu/softfloat-macros.h:105:
+    if ( count == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#38: FILE: fpu/softfloat-macros.h:105:
+    if ( count == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#41: FILE: fpu/softfloat-macros.h:108:
+    else if ( count < 16 ) {

ERROR: space prohibited before that close parenthesis ')'
#41: FILE: fpu/softfloat-macros.h:108:
+    else if ( count < 16 ) {

ERROR: else should follow close brace '}'
#41: FILE: fpu/softfloat-macros.h:108:
+    }
+    else if ( count < 16 ) {

ERROR: spaces required around that '>>' (ctx:VxV)
#42: FILE: fpu/softfloat-macros.h:109:
+        z = ( a>>count ) | ( ( a<<( ( - count ) & 16 ) ) != 0 );
                ^

ERROR: spaces required around that '<<' (ctx:VxV)
#42: FILE: fpu/softfloat-macros.h:109:
+        z = ( a>>count ) | ( ( a<<( ( - count ) & 16 ) ) != 0 );
                                 ^

ERROR: space prohibited after that '-' (ctx:WxW)
#42: FILE: fpu/softfloat-macros.h:109:
+        z = ( a>>count ) | ( ( a<<( ( - count ) & 16 ) ) != 0 );
                                       ^

ERROR: space prohibited after that open parenthesis '('
#42: FILE: fpu/softfloat-macros.h:109:
+        z = ( a>>count ) | ( ( a<<( ( - count ) & 16 ) ) != 0 );

ERROR: space prohibited before that close parenthesis ')'
#42: FILE: fpu/softfloat-macros.h:109:
+        z = ( a>>count ) | ( ( a<<( ( - count ) & 16 ) ) != 0 );

ERROR: else should follow close brace '}'
#44: FILE: fpu/softfloat-macros.h:111:
+    }
+    else {

ERROR: space prohibited after that open parenthesis '('
#45: FILE: fpu/softfloat-macros.h:112:
+        z = ( a != 0 );

ERROR: space prohibited before that close parenthesis ')'
#45: FILE: fpu/softfloat-macros.h:112:
+        z = ( a != 0 );

ERROR: space prohibited after that open parenthesis '('
#60: FILE: fpu/softfloat-macros.h:697:
+static int8_t countLeadingZeros16( uint16_t a )

ERROR: space prohibited before that close parenthesis ')'
#60: FILE: fpu/softfloat-macros.h:697:
+static int8_t countLeadingZeros16( uint16_t a )

ERROR: space prohibited after that open parenthesis '('
#96: FILE: fpu/softfloat.c:3506:
+    shiftCount = countLeadingZeros16( zSig ) - 1;

ERROR: space prohibited before that close parenthesis ')'
#96: FILE: fpu/softfloat.c:3506:
+    shiftCount = countLeadingZeros16( zSig ) - 1;

ERROR: spaces required around that '<<' (ctx:VxV)
#97: FILE: fpu/softfloat.c:3507:
+    return roundAndPackFloat16(zSign, zExp - shiftCount, zSig<<shiftCount,
                                                              ^

total: 18 errors, 0 warnings, 78 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 15/30: softfloat: half-precision add/sub/mul/div support...
ERROR: space prohibited after that open parenthesis '('
#40: FILE: fpu/softfloat.c:3550:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited before that close parenthesis ')'
#40: FILE: fpu/softfloat.c:3550:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited after that open parenthesis '('
#41: FILE: fpu/softfloat.c:3551:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited before that close parenthesis ')'
#41: FILE: fpu/softfloat.c:3551:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited after that open parenthesis '('
#42: FILE: fpu/softfloat.c:3552:
+    bSig = extractFloat16Frac( b );

ERROR: space prohibited before that close parenthesis ')'
#42: FILE: fpu/softfloat.c:3552:
+    bSig = extractFloat16Frac( b );

ERROR: space prohibited after that open parenthesis '('
#43: FILE: fpu/softfloat.c:3553:
+    bExp = extractFloat16Exp( b );

ERROR: space prohibited before that close parenthesis ')'
#43: FILE: fpu/softfloat.c:3553:
+    bExp = extractFloat16Exp( b );

ERROR: space prohibited after that open parenthesis '('
#47: FILE: fpu/softfloat.c:3557:
+    if ( 0 < expDiff ) {

ERROR: space prohibited before that close parenthesis ')'
#47: FILE: fpu/softfloat.c:3557:
+    if ( 0 < expDiff ) {

ERROR: space prohibited after that open parenthesis '('
#48: FILE: fpu/softfloat.c:3558:
+        if ( aExp == 0x1F ) {

ERROR: space prohibited before that close parenthesis ')'
#48: FILE: fpu/softfloat.c:3558:
+        if ( aExp == 0x1F ) {

ERROR: space prohibited after that open parenthesis '('
#54: FILE: fpu/softfloat.c:3564:
+        if ( bExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#54: FILE: fpu/softfloat.c:3564:
+        if ( bExp == 0 ) {

ERROR: else should follow close brace '}'
#57: FILE: fpu/softfloat.c:3567:
+        }
+        else {

ERROR: space prohibited after that open parenthesis '('
#60: FILE: fpu/softfloat.c:3570:
+        shift16RightJamming( bSig, expDiff, &bSig );

ERROR: space prohibited before that close parenthesis ')'
#60: FILE: fpu/softfloat.c:3570:
+        shift16RightJamming( bSig, expDiff, &bSig );

ERROR: space prohibited after that open parenthesis '('
#63: FILE: fpu/softfloat.c:3573:
+    else if ( expDiff < 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#63: FILE: fpu/softfloat.c:3573:
+    else if ( expDiff < 0 ) {

ERROR: else should follow close brace '}'
#63: FILE: fpu/softfloat.c:3573:
+    }
+    else if ( expDiff < 0 ) {

ERROR: space prohibited after that open parenthesis '('
#64: FILE: fpu/softfloat.c:3574:
+        if ( bExp == 0x1F ) {

ERROR: space prohibited before that close parenthesis ')'
#64: FILE: fpu/softfloat.c:3574:
+        if ( bExp == 0x1F ) {

ERROR: space prohibited after that open parenthesis '('
#68: FILE: fpu/softfloat.c:3578:
+            return packFloat16( zSign, 0x1F, 0 );

ERROR: space prohibited before that close parenthesis ')'
#68: FILE: fpu/softfloat.c:3578:
+            return packFloat16( zSign, 0x1F, 0 );

ERROR: space prohibited after that open parenthesis '('
#70: FILE: fpu/softfloat.c:3580:
+        if ( aExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#70: FILE: fpu/softfloat.c:3580:
+        if ( aExp == 0 ) {

ERROR: else should follow close brace '}'
#73: FILE: fpu/softfloat.c:3583:
+        }
+        else {

ERROR: space prohibited after that '-' (ctx:WxW)
#76: FILE: fpu/softfloat.c:3586:
+        shift16RightJamming( aSig, - expDiff, &aSig );
                                    ^

ERROR: space prohibited after that open parenthesis '('
#76: FILE: fpu/softfloat.c:3586:
+        shift16RightJamming( aSig, - expDiff, &aSig );

ERROR: space prohibited before that close parenthesis ')'
#76: FILE: fpu/softfloat.c:3586:
+        shift16RightJamming( aSig, - expDiff, &aSig );

ERROR: else should follow close brace '}'
#79: FILE: fpu/softfloat.c:3589:
+    }
+    else {

ERROR: space prohibited after that open parenthesis '('
#80: FILE: fpu/softfloat.c:3590:
+        if ( aExp == 0x1F ) {

ERROR: space prohibited before that close parenthesis ')'
#80: FILE: fpu/softfloat.c:3590:
+        if ( aExp == 0x1F ) {

ERROR: space prohibited after that open parenthesis '('
#86: FILE: fpu/softfloat.c:3596:
+        if ( aExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#86: FILE: fpu/softfloat.c:3596:
+        if ( aExp == 0 ) {

ERROR: spaces required around that '>>' (ctx:VxV)
#93: FILE: fpu/softfloat.c:3603:
+            return packFloat16( zSign, 0, ( aSig + bSig )>>3 );
                                                          ^

ERROR: space prohibited after that open parenthesis '('
#93: FILE: fpu/softfloat.c:3603:
+            return packFloat16( zSign, 0, ( aSig + bSig )>>3 );

ERROR: space prohibited before that close parenthesis ')'
#93: FILE: fpu/softfloat.c:3603:
+            return packFloat16( zSign, 0, ( aSig + bSig )>>3 );

ERROR: spaces required around that '<<' (ctx:VxV)
#100: FILE: fpu/softfloat.c:3610:
+    zSig = ( aSig + bSig )<<1;
                           ^

ERROR: space prohibited after that open parenthesis '('
#100: FILE: fpu/softfloat.c:3610:
+    zSig = ( aSig + bSig )<<1;

ERROR: space prohibited before that close parenthesis ')'
#100: FILE: fpu/softfloat.c:3610:
+    zSig = ( aSig + bSig )<<1;

ERROR: space prohibited after that open parenthesis '('
#102: FILE: fpu/softfloat.c:3612:
+    if ( (int16_t) zSig < 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#102: FILE: fpu/softfloat.c:3612:
+    if ( (int16_t) zSig < 0 ) {

ERROR: space prohibited after that open parenthesis '('
#126: FILE: fpu/softfloat.c:3636:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited before that close parenthesis ')'
#126: FILE: fpu/softfloat.c:3636:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited after that open parenthesis '('
#127: FILE: fpu/softfloat.c:3637:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited before that close parenthesis ')'
#127: FILE: fpu/softfloat.c:3637:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited after that open parenthesis '('
#128: FILE: fpu/softfloat.c:3638:
+    bSig = extractFloat16Frac( b );

ERROR: space prohibited before that close parenthesis ')'
#128: FILE: fpu/softfloat.c:3638:
+    bSig = extractFloat16Frac( b );

ERROR: space prohibited after that open parenthesis '('
#129: FILE: fpu/softfloat.c:3639:
+    bExp = extractFloat16Exp( b );

ERROR: space prohibited before that close parenthesis ')'
#129: FILE: fpu/softfloat.c:3639:
+    bExp = extractFloat16Exp( b );

ERROR: space prohibited after that open parenthesis '('
#133: FILE: fpu/softfloat.c:3643:
+    if ( 0 < expDiff ) goto aExpBigger;

ERROR: space prohibited before that close parenthesis ')'
#133: FILE: fpu/softfloat.c:3643:
+    if ( 0 < expDiff ) goto aExpBigger;

ERROR: trailing statements should be on next line
#133: FILE: fpu/softfloat.c:3643:
+    if ( 0 < expDiff ) goto aExpBigger;

ERROR: braces {} are necessary for all arms of this statement
#133: FILE: fpu/softfloat.c:3643:
+    if ( 0 < expDiff ) goto aExpBigger;
[...]

ERROR: space prohibited after that open parenthesis '('
#134: FILE: fpu/softfloat.c:3644:
+    if ( expDiff < 0 ) goto bExpBigger;

ERROR: space prohibited before that close parenthesis ')'
#134: FILE: fpu/softfloat.c:3644:
+    if ( expDiff < 0 ) goto bExpBigger;

ERROR: trailing statements should be on next line
#134: FILE: fpu/softfloat.c:3644:
+    if ( expDiff < 0 ) goto bExpBigger;

ERROR: braces {} are necessary for all arms of this statement
#134: FILE: fpu/softfloat.c:3644:
+    if ( expDiff < 0 ) goto bExpBigger;
[...]

ERROR: space prohibited after that open parenthesis '('
#135: FILE: fpu/softfloat.c:3645:
+    if ( aExp == 0xFF ) {

ERROR: space prohibited before that close parenthesis ')'
#135: FILE: fpu/softfloat.c:3645:
+    if ( aExp == 0xFF ) {

ERROR: space prohibited after that open parenthesis '('
#142: FILE: fpu/softfloat.c:3652:
+    if ( aExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#142: FILE: fpu/softfloat.c:3652:
+    if ( aExp == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#146: FILE: fpu/softfloat.c:3656:
+    if ( bSig < aSig ) goto aBigger;

ERROR: space prohibited before that close parenthesis ')'
#146: FILE: fpu/softfloat.c:3656:
+    if ( bSig < aSig ) goto aBigger;

ERROR: trailing statements should be on next line
#146: FILE: fpu/softfloat.c:3656:
+    if ( bSig < aSig ) goto aBigger;

ERROR: braces {} are necessary for all arms of this statement
#146: FILE: fpu/softfloat.c:3656:
+    if ( bSig < aSig ) goto aBigger;
[...]

ERROR: space prohibited after that open parenthesis '('
#147: FILE: fpu/softfloat.c:3657:
+    if ( aSig < bSig ) goto bBigger;

ERROR: space prohibited before that close parenthesis ')'
#147: FILE: fpu/softfloat.c:3657:
+    if ( aSig < bSig ) goto bBigger;

ERROR: trailing statements should be on next line
#147: FILE: fpu/softfloat.c:3657:
+    if ( aSig < bSig ) goto bBigger;

ERROR: braces {} are necessary for all arms of this statement
#147: FILE: fpu/softfloat.c:3657:
+    if ( aSig < bSig ) goto bBigger;
[...]

ERROR: space prohibited after that open parenthesis '('
#150: FILE: fpu/softfloat.c:3660:
+    if ( bExp == 0xFF ) {

ERROR: space prohibited before that close parenthesis ')'
#150: FILE: fpu/softfloat.c:3660:
+    if ( bExp == 0xFF ) {

ERROR: space prohibited after that open parenthesis '('
#154: FILE: fpu/softfloat.c:3664:
+        return packFloat16( zSign ^ 1, 0xFF, 0 );

ERROR: space prohibited before that close parenthesis ')'
#154: FILE: fpu/softfloat.c:3664:
+        return packFloat16( zSign ^ 1, 0xFF, 0 );

ERROR: space prohibited after that open parenthesis '('
#156: FILE: fpu/softfloat.c:3666:
+    if ( aExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#156: FILE: fpu/softfloat.c:3666:
+    if ( aExp == 0 ) {

ERROR: else should follow close brace '}'
#159: FILE: fpu/softfloat.c:3669:
+    }
+    else {

ERROR: space prohibited after that '-' (ctx:WxW)
#162: FILE: fpu/softfloat.c:3672:
+    shift16RightJamming( aSig, - expDiff, &aSig );
                                ^

ERROR: space prohibited after that open parenthesis '('
#162: FILE: fpu/softfloat.c:3672:
+    shift16RightJamming( aSig, - expDiff, &aSig );

ERROR: space prohibited before that close parenthesis ')'
#162: FILE: fpu/softfloat.c:3672:
+    shift16RightJamming( aSig, - expDiff, &aSig );

ERROR: space prohibited after that open parenthesis '('
#170: FILE: fpu/softfloat.c:3680:
+    if ( aExp == 0xFF ) {

ERROR: space prohibited before that close parenthesis ')'
#170: FILE: fpu/softfloat.c:3680:
+    if ( aExp == 0xFF ) {

ERROR: space prohibited after that open parenthesis '('
#176: FILE: fpu/softfloat.c:3686:
+    if ( bExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#176: FILE: fpu/softfloat.c:3686:
+    if ( bExp == 0 ) {

ERROR: else should follow close brace '}'
#179: FILE: fpu/softfloat.c:3689:
+    }
+    else {

ERROR: space prohibited after that open parenthesis '('
#182: FILE: fpu/softfloat.c:3692:
+    shift16RightJamming( bSig, expDiff, &bSig );

ERROR: space prohibited before that close parenthesis ')'
#182: FILE: fpu/softfloat.c:3692:
+    shift16RightJamming( bSig, expDiff, &bSig );

ERROR: space prohibited after that open parenthesis '('
#205: FILE: fpu/softfloat.c:3715:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#205: FILE: fpu/softfloat.c:3715:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#206: FILE: fpu/softfloat.c:3716:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited before that close parenthesis ')'
#206: FILE: fpu/softfloat.c:3716:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited after that open parenthesis '('
#207: FILE: fpu/softfloat.c:3717:
+    if ( aSign == bSign ) {

ERROR: space prohibited before that close parenthesis ')'
#207: FILE: fpu/softfloat.c:3717:
+    if ( aSign == bSign ) {

ERROR: else should follow close brace '}'
#210: FILE: fpu/softfloat.c:3720:
+    }
+    else {

ERROR: space prohibited after that open parenthesis '('
#228: FILE: fpu/softfloat.c:3738:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#228: FILE: fpu/softfloat.c:3738:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#229: FILE: fpu/softfloat.c:3739:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited before that close parenthesis ')'
#229: FILE: fpu/softfloat.c:3739:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited after that open parenthesis '('
#230: FILE: fpu/softfloat.c:3740:
+    if ( aSign == bSign ) {

ERROR: space prohibited before that close parenthesis ')'
#230: FILE: fpu/softfloat.c:3740:
+    if ( aSign == bSign ) {

ERROR: else should follow close brace '}'
#233: FILE: fpu/softfloat.c:3743:
+    }
+    else {

ERROR: space prohibited after that open parenthesis '('
#255: FILE: fpu/softfloat.c:3765:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited before that close parenthesis ')'
#255: FILE: fpu/softfloat.c:3765:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited after that open parenthesis '('
#256: FILE: fpu/softfloat.c:3766:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited before that close parenthesis ')'
#256: FILE: fpu/softfloat.c:3766:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited after that open parenthesis '('
#257: FILE: fpu/softfloat.c:3767:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#257: FILE: fpu/softfloat.c:3767:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#258: FILE: fpu/softfloat.c:3768:
+    bSig = extractFloat16Frac( b );

ERROR: space prohibited before that close parenthesis ')'
#258: FILE: fpu/softfloat.c:3768:
+    bSig = extractFloat16Frac( b );

ERROR: space prohibited after that open parenthesis '('
#259: FILE: fpu/softfloat.c:3769:
+    bExp = extractFloat16Exp( b );

ERROR: space prohibited before that close parenthesis ')'
#259: FILE: fpu/softfloat.c:3769:
+    bExp = extractFloat16Exp( b );

ERROR: space prohibited after that open parenthesis '('
#260: FILE: fpu/softfloat.c:3770:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited before that close parenthesis ')'
#260: FILE: fpu/softfloat.c:3770:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited after that open parenthesis '('
#262: FILE: fpu/softfloat.c:3772:
+    if ( aExp == 0x1F ) {

ERROR: space prohibited before that close parenthesis ')'
#262: FILE: fpu/softfloat.c:3772:
+    if ( aExp == 0x1F ) {

ERROR: space prohibited after that open parenthesis '('
#263: FILE: fpu/softfloat.c:3773:
+        if ( aSig || ( ( bExp == 0x1F ) && bSig ) ) {

ERROR: space prohibited before that close parenthesis ')'
#263: FILE: fpu/softfloat.c:3773:
+        if ( aSig || ( ( bExp == 0x1F ) && bSig ) ) {

ERROR: space prohibited after that open parenthesis '('
#266: FILE: fpu/softfloat.c:3776:
+        if ( ( bExp | bSig ) == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#266: FILE: fpu/softfloat.c:3776:
+        if ( ( bExp | bSig ) == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#270: FILE: fpu/softfloat.c:3780:
+        return packFloat16( zSign, 0x1F, 0 );

ERROR: space prohibited before that close parenthesis ')'
#270: FILE: fpu/softfloat.c:3780:
+        return packFloat16( zSign, 0x1F, 0 );

ERROR: space prohibited after that open parenthesis '('
#272: FILE: fpu/softfloat.c:3782:
+    if ( bExp == 0x1F ) {

ERROR: space prohibited before that close parenthesis ')'
#272: FILE: fpu/softfloat.c:3782:
+    if ( bExp == 0x1F ) {

ERROR: space prohibited after that open parenthesis '('
#276: FILE: fpu/softfloat.c:3786:
+        if ( ( aExp | aSig ) == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#276: FILE: fpu/softfloat.c:3786:
+        if ( ( aExp | aSig ) == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#280: FILE: fpu/softfloat.c:3790:
+        return packFloat16( zSign, 0x1F, 0 );

ERROR: space prohibited before that close parenthesis ')'
#280: FILE: fpu/softfloat.c:3790:
+        return packFloat16( zSign, 0x1F, 0 );

ERROR: space prohibited after that open parenthesis '('
#282: FILE: fpu/softfloat.c:3792:
+    if ( aExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#282: FILE: fpu/softfloat.c:3792:
+    if ( aExp == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#283: FILE: fpu/softfloat.c:3793:
+        if ( aSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: space prohibited before that close parenthesis ')'
#283: FILE: fpu/softfloat.c:3793:
+        if ( aSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: trailing statements should be on next line
#283: FILE: fpu/softfloat.c:3793:
+        if ( aSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: braces {} are necessary for all arms of this statement
#283: FILE: fpu/softfloat.c:3793:
+        if ( aSig == 0 ) return packFloat16( zSign, 0, 0 );
[...]

ERROR: space prohibited after that open parenthesis '('
#284: FILE: fpu/softfloat.c:3794:
+        normalizeFloat16Subnormal( aSig, &aExp, &aSig );

ERROR: space prohibited before that close parenthesis ')'
#284: FILE: fpu/softfloat.c:3794:
+        normalizeFloat16Subnormal( aSig, &aExp, &aSig );

ERROR: space prohibited after that open parenthesis '('
#286: FILE: fpu/softfloat.c:3796:
+    if ( bExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#286: FILE: fpu/softfloat.c:3796:
+    if ( bExp == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#287: FILE: fpu/softfloat.c:3797:
+        if ( bSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: space prohibited before that close parenthesis ')'
#287: FILE: fpu/softfloat.c:3797:
+        if ( bSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: trailing statements should be on next line
#287: FILE: fpu/softfloat.c:3797:
+        if ( bSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: braces {} are necessary for all arms of this statement
#287: FILE: fpu/softfloat.c:3797:
+        if ( bSig == 0 ) return packFloat16( zSign, 0, 0 );
[...]

ERROR: space prohibited after that open parenthesis '('
#288: FILE: fpu/softfloat.c:3798:
+        normalizeFloat16Subnormal( bSig, &bExp, &bSig );

ERROR: space prohibited before that close parenthesis ')'
#288: FILE: fpu/softfloat.c:3798:
+        normalizeFloat16Subnormal( bSig, &bExp, &bSig );

ERROR: spaces required around that '<<' (ctx:VxV)
#292: FILE: fpu/softfloat.c:3802:
+    aSig = ( aSig | 0x0400 )<<4;
                             ^

ERROR: space prohibited after that open parenthesis '('
#292: FILE: fpu/softfloat.c:3802:
+    aSig = ( aSig | 0x0400 )<<4;

ERROR: space prohibited before that close parenthesis ')'
#292: FILE: fpu/softfloat.c:3802:
+    aSig = ( aSig | 0x0400 )<<4;

ERROR: spaces required around that '<<' (ctx:VxV)
#293: FILE: fpu/softfloat.c:3803:
+    bSig = ( bSig | 0x0400 )<<5;
                             ^

ERROR: space prohibited after that open parenthesis '('
#293: FILE: fpu/softfloat.c:3803:
+    bSig = ( bSig | 0x0400 )<<5;

ERROR: space prohibited before that close parenthesis ')'
#293: FILE: fpu/softfloat.c:3803:
+    bSig = ( bSig | 0x0400 )<<5;

ERROR: space prohibited after that open parenthesis '('
#297: FILE: fpu/softfloat.c:3807:
+    shift32RightJamming( ( (uint32_t) aSig ) * bSig, 7, &zSig32 );

ERROR: space prohibited before that close parenthesis ')'
#297: FILE: fpu/softfloat.c:3807:
+    shift32RightJamming( ( (uint32_t) aSig ) * bSig, 7, &zSig32 );

ERROR: spaces required around that '<<' (ctx:VxV)
#300: FILE: fpu/softfloat.c:3810:
+    if ( 0 <= (int32_t) ( zSig32<<1 ) ) {
                                 ^

ERROR: space prohibited after that open parenthesis '('
#300: FILE: fpu/softfloat.c:3810:
+    if ( 0 <= (int32_t) ( zSig32<<1 ) ) {

ERROR: space prohibited before that close parenthesis ')'
#300: FILE: fpu/softfloat.c:3810:
+    if ( 0 <= (int32_t) ( zSig32<<1 ) ) {

ERROR: space prohibited after that open parenthesis '('
#321: FILE: fpu/softfloat.c:3831:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited before that close parenthesis ')'
#321: FILE: fpu/softfloat.c:3831:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited after that open parenthesis '('
#322: FILE: fpu/softfloat.c:3832:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited before that close parenthesis ')'
#322: FILE: fpu/softfloat.c:3832:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited after that open parenthesis '('
#323: FILE: fpu/softfloat.c:3833:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#323: FILE: fpu/softfloat.c:3833:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#324: FILE: fpu/softfloat.c:3834:
+    bSig = extractFloat16Frac( b );

ERROR: space prohibited before that close parenthesis ')'
#324: FILE: fpu/softfloat.c:3834:
+    bSig = extractFloat16Frac( b );

ERROR: space prohibited after that open parenthesis '('
#325: FILE: fpu/softfloat.c:3835:
+    bExp = extractFloat16Exp( b );

ERROR: space prohibited before that close parenthesis ')'
#325: FILE: fpu/softfloat.c:3835:
+    bExp = extractFloat16Exp( b );

ERROR: space prohibited after that open parenthesis '('
#326: FILE: fpu/softfloat.c:3836:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited before that close parenthesis ')'
#326: FILE: fpu/softfloat.c:3836:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited after that open parenthesis '('
#328: FILE: fpu/softfloat.c:3838:
+    if ( aExp == 0xFF ) {

ERROR: space prohibited before that close parenthesis ')'
#328: FILE: fpu/softfloat.c:3838:
+    if ( aExp == 0xFF ) {

ERROR: space prohibited after that open parenthesis '('
#332: FILE: fpu/softfloat.c:3842:
+        if ( bExp == 0xFF ) {

ERROR: space prohibited before that close parenthesis ')'
#332: FILE: fpu/softfloat.c:3842:
+        if ( bExp == 0xFF ) {

ERROR: space prohibited after that open parenthesis '('
#339: FILE: fpu/softfloat.c:3849:
+        return packFloat16( zSign, 0xFF, 0 );

ERROR: space prohibited before that close parenthesis ')'
#339: FILE: fpu/softfloat.c:3849:
+        return packFloat16( zSign, 0xFF, 0 );

ERROR: space prohibited after that open parenthesis '('
#341: FILE: fpu/softfloat.c:3851:
+    if ( bExp == 0xFF ) {

ERROR: space prohibited before that close parenthesis ')'
#341: FILE: fpu/softfloat.c:3851:
+    if ( bExp == 0xFF ) {

ERROR: space prohibited after that open parenthesis '('
#345: FILE: fpu/softfloat.c:3855:
+        return packFloat16( zSign, 0, 0 );

ERROR: space prohibited before that close parenthesis ')'
#345: FILE: fpu/softfloat.c:3855:
+        return packFloat16( zSign, 0, 0 );

ERROR: space prohibited after that open parenthesis '('
#347: FILE: fpu/softfloat.c:3857:
+    if ( bExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#347: FILE: fpu/softfloat.c:3857:
+    if ( bExp == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#348: FILE: fpu/softfloat.c:3858:
+        if ( bSig == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#348: FILE: fpu/softfloat.c:3858:
+        if ( bSig == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#349: FILE: fpu/softfloat.c:3859:
+            if ( ( aExp | aSig ) == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#349: FILE: fpu/softfloat.c:3859:
+            if ( ( aExp | aSig ) == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#354: FILE: fpu/softfloat.c:3864:
+            return packFloat16( zSign, 0xFF, 0 );

ERROR: space prohibited before that close parenthesis ')'
#354: FILE: fpu/softfloat.c:3864:
+            return packFloat16( zSign, 0xFF, 0 );

ERROR: space prohibited after that open parenthesis '('
#356: FILE: fpu/softfloat.c:3866:
+        normalizeFloat16Subnormal( bSig, &bExp, &bSig );

ERROR: space prohibited before that close parenthesis ')'
#356: FILE: fpu/softfloat.c:3866:
+        normalizeFloat16Subnormal( bSig, &bExp, &bSig );

ERROR: space prohibited after that open parenthesis '('
#358: FILE: fpu/softfloat.c:3868:
+    if ( aExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#358: FILE: fpu/softfloat.c:3868:
+    if ( aExp == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#359: FILE: fpu/softfloat.c:3869:
+        if ( aSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: space prohibited before that close parenthesis ')'
#359: FILE: fpu/softfloat.c:3869:
+        if ( aSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: trailing statements should be on next line
#359: FILE: fpu/softfloat.c:3869:
+        if ( aSig == 0 ) return packFloat16( zSign, 0, 0 );

ERROR: braces {} are necessary for all arms of this statement
#359: FILE: fpu/softfloat.c:3869:
+        if ( aSig == 0 ) return packFloat16( zSign, 0, 0 );
[...]

ERROR: space prohibited after that open parenthesis '('
#360: FILE: fpu/softfloat.c:3870:
+        normalizeFloat16Subnormal( aSig, &aExp, &aSig );

ERROR: space prohibited before that close parenthesis ')'
#360: FILE: fpu/softfloat.c:3870:
+        normalizeFloat16Subnormal( aSig, &aExp, &aSig );

ERROR: spaces required around that '<<' (ctx:VxV)
#363: FILE: fpu/softfloat.c:3873:
+    aSig = ( aSig | 0x00800000 )<<7;
                                 ^

ERROR: space prohibited after that open parenthesis '('
#363: FILE: fpu/softfloat.c:3873:
+    aSig = ( aSig | 0x00800000 )<<7;

ERROR: space prohibited before that close parenthesis ')'
#363: FILE: fpu/softfloat.c:3873:
+    aSig = ( aSig | 0x00800000 )<<7;

ERROR: spaces required around that '<<' (ctx:VxV)
#364: FILE: fpu/softfloat.c:3874:
+    bSig = ( bSig | 0x00800000 )<<8;
                                 ^

ERROR: space prohibited after that open parenthesis '('
#364: FILE: fpu/softfloat.c:3874:
+    bSig = ( bSig | 0x00800000 )<<8;

ERROR: space prohibited before that close parenthesis ')'
#364: FILE: fpu/softfloat.c:3874:
+    bSig = ( bSig | 0x00800000 )<<8;

ERROR: space prohibited after that open parenthesis '('
#365: FILE: fpu/softfloat.c:3875:
+    if ( bSig <= ( aSig + aSig ) ) {

ERROR: space prohibited before that close parenthesis ')'
#365: FILE: fpu/softfloat.c:3875:
+    if ( bSig <= ( aSig + aSig ) ) {

ERROR: spaces required around that '<<' (ctx:VxV)
#369: FILE: fpu/softfloat.c:3879:
+    zSig = ( ( (uint64_t) aSig )<<16 ) / bSig;
                                 ^

ERROR: space prohibited after that open parenthesis '('
#369: FILE: fpu/softfloat.c:3879:
+    zSig = ( ( (uint64_t) aSig )<<16 ) / bSig;

ERROR: space prohibited before that close parenthesis ')'
#369: FILE: fpu/softfloat.c:3879:
+    zSig = ( ( (uint64_t) aSig )<<16 ) / bSig;

ERROR: space prohibited after that open parenthesis '('
#370: FILE: fpu/softfloat.c:3880:
+    if ( ( zSig & 0x3F ) == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#370: FILE: fpu/softfloat.c:3880:
+    if ( ( zSig & 0x3F ) == 0 ) {

ERROR: spaces required around that '<<' (ctx:VxV)
#371: FILE: fpu/softfloat.c:3881:
+        zSig |= ( (uint64_t) bSig * zSig != ( (uint64_t) aSig )<<16 );
                                                                ^

ERROR: space prohibited after that open parenthesis '('
#371: FILE: fpu/softfloat.c:3881:
+        zSig |= ( (uint64_t) bSig * zSig != ( (uint64_t) aSig )<<16 );

ERROR: space prohibited before that close parenthesis ')'
#371: FILE: fpu/softfloat.c:3881:
+        zSig |= ( (uint64_t) bSig * zSig != ( (uint64_t) aSig )<<16 );

total: 211 errors, 0 warnings, 370 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 16/30: target/arm/translate-a64.c: add FP16 FADD/FMUL/FDIV to 
AdvSIMD 3 Same (!sub)...
ERROR: space required after that ',' (ctx:VxV)
#65: FILE: target/arm/translate-a64.c:9819:
+            fprintf(stderr,"%s: insn %#04x, fpop %#2x @ %#" PRIx64 "\n",
                           ^

total: 1 errors, 0 warnings, 39 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 17/30: target/arm/translate-a64.c: add FP16 FMULX...
WARNING: line over 80 characters
#107: FILE: target/arm/translate-a64.c:10823:
+                        gen_helper_advsimd_mulxh(tcg_res, tcg_op, tcg_idx, 
fpst);

total: 0 errors, 1 warnings, 95 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 18/30: target/arm/translate-a64.c: add AdvSIMD scalar two-reg 
misc skeleton...
ERROR: space required after that ',' (ctx:VxV)
#52: FILE: target/arm/translate-a64.c:10599:
+        fprintf(stderr,"%s: insn %#04x fpop %#2x\n", __func__, insn, fpop);
                       ^

total: 1 errors, 0 warnings, 47 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/30: Fix mask for AdvancedSIMD 2 reg misc...
Checking PATCH 20/30: softfloat: half-precision compare functions...
ERROR: space prohibited after that open parenthesis '('
#37: FILE: fpu/softfloat.c:3900:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited before that close parenthesis ')'
#37: FILE: fpu/softfloat.c:3900:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited after that open parenthesis '('
#38: FILE: fpu/softfloat.c:3901:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited before that close parenthesis ')'
#38: FILE: fpu/softfloat.c:3901:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: spaces required around that '<<' (ctx:VxV)
#45: FILE: fpu/softfloat.c:3908:
+    return ( av == bv ) || ( (uint32_t) ( ( av | bv )<<1 ) == 0 );
                                                      ^

ERROR: space prohibited after that open parenthesis '('
#45: FILE: fpu/softfloat.c:3908:
+    return ( av == bv ) || ( (uint32_t) ( ( av | bv )<<1 ) == 0 );

ERROR: space prohibited before that close parenthesis ')'
#45: FILE: fpu/softfloat.c:3908:
+    return ( av == bv ) || ( (uint32_t) ( ( av | bv )<<1 ) == 0 );

ERROR: space prohibited after that open parenthesis '('
#62: FILE: fpu/softfloat.c:3925:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited before that close parenthesis ')'
#62: FILE: fpu/softfloat.c:3925:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited after that open parenthesis '('
#63: FILE: fpu/softfloat.c:3926:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited before that close parenthesis ')'
#63: FILE: fpu/softfloat.c:3926:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited after that open parenthesis '('
#68: FILE: fpu/softfloat.c:3931:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#68: FILE: fpu/softfloat.c:3931:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#69: FILE: fpu/softfloat.c:3932:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited before that close parenthesis ')'
#69: FILE: fpu/softfloat.c:3932:
+    bSign = extractFloat16Sign( b );

WARNING: line over 80 characters
#72: FILE: fpu/softfloat.c:3935:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);

ERROR: spaces required around that '<<' (ctx:VxV)
#72: FILE: fpu/softfloat.c:3935:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);
                                                                     ^

ERROR: space prohibited after that open parenthesis '('
#72: FILE: fpu/softfloat.c:3935:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);

ERROR: space prohibited before that close parenthesis ')'
#72: FILE: fpu/softfloat.c:3935:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);

ERROR: trailing statements should be on next line
#72: FILE: fpu/softfloat.c:3935:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);

ERROR: braces {} are necessary for all arms of this statement
#72: FILE: fpu/softfloat.c:3935:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);
[...]

ERROR: space prohibited after that open parenthesis '('
#73: FILE: fpu/softfloat.c:3936:
+    return ( av == bv ) || ( aSign ^ ( av < bv ) );

ERROR: space prohibited before that close parenthesis ')'
#73: FILE: fpu/softfloat.c:3936:
+    return ( av == bv ) || ( aSign ^ ( av < bv ) );

ERROR: space prohibited after that open parenthesis '('
#91: FILE: fpu/softfloat.c:3954:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited before that close parenthesis ')'
#91: FILE: fpu/softfloat.c:3954:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited after that open parenthesis '('
#92: FILE: fpu/softfloat.c:3955:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited before that close parenthesis ')'
#92: FILE: fpu/softfloat.c:3955:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited after that open parenthesis '('
#97: FILE: fpu/softfloat.c:3960:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#97: FILE: fpu/softfloat.c:3960:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#98: FILE: fpu/softfloat.c:3961:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited before that close parenthesis ')'
#98: FILE: fpu/softfloat.c:3961:
+    bSign = extractFloat16Sign( b );

WARNING: line over 80 characters
#101: FILE: fpu/softfloat.c:3964:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);

ERROR: spaces required around that '<<' (ctx:VxV)
#101: FILE: fpu/softfloat.c:3964:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);
                                                                     ^

ERROR: space prohibited after that open parenthesis '('
#101: FILE: fpu/softfloat.c:3964:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);

ERROR: space prohibited before that close parenthesis ')'
#101: FILE: fpu/softfloat.c:3964:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);

ERROR: trailing statements should be on next line
#101: FILE: fpu/softfloat.c:3964:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);

ERROR: braces {} are necessary for all arms of this statement
#101: FILE: fpu/softfloat.c:3964:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);
[...]

ERROR: space prohibited after that open parenthesis '('
#102: FILE: fpu/softfloat.c:3965:
+    return ( av != bv ) && ( aSign ^ ( av < bv ) );

ERROR: space prohibited before that close parenthesis ')'
#102: FILE: fpu/softfloat.c:3965:
+    return ( av != bv ) && ( aSign ^ ( av < bv ) );

ERROR: space prohibited after that open parenthesis '('
#118: FILE: fpu/softfloat.c:3981:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited before that close parenthesis ')'
#118: FILE: fpu/softfloat.c:3981:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited after that open parenthesis '('
#119: FILE: fpu/softfloat.c:3982:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited before that close parenthesis ')'
#119: FILE: fpu/softfloat.c:3982:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited after that open parenthesis '('
#139: FILE: fpu/softfloat.c:4002:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited before that close parenthesis ')'
#139: FILE: fpu/softfloat.c:4002:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited after that open parenthesis '('
#140: FILE: fpu/softfloat.c:4003:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited before that close parenthesis ')'
#140: FILE: fpu/softfloat.c:4003:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited after that open parenthesis '('
#148: FILE: fpu/softfloat.c:4011:
+    return ( float16_val(a) == float16_val(b) ) ||

ERROR: space prohibited before that close parenthesis ')'
#148: FILE: fpu/softfloat.c:4011:
+    return ( float16_val(a) == float16_val(b) ) ||

ERROR: spaces required around that '<<' (ctx:VxV)
#149: FILE: fpu/softfloat.c:4012:
+            ( (uint32_t) ( ( float16_val(a) | float16_val(b) )<<1 ) == 0 );
                                                               ^

ERROR: space prohibited after that open parenthesis '('
#149: FILE: fpu/softfloat.c:4012:
+            ( (uint32_t) ( ( float16_val(a) | float16_val(b) )<<1 ) == 0 );

ERROR: space prohibited before that close parenthesis ')'
#149: FILE: fpu/softfloat.c:4012:
+            ( (uint32_t) ( ( float16_val(a) | float16_val(b) )<<1 ) == 0 );

ERROR: space prohibited after that open parenthesis '('
#166: FILE: fpu/softfloat.c:4029:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited before that close parenthesis ')'
#166: FILE: fpu/softfloat.c:4029:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited after that open parenthesis '('
#167: FILE: fpu/softfloat.c:4030:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited before that close parenthesis ')'
#167: FILE: fpu/softfloat.c:4030:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited after that open parenthesis '('
#175: FILE: fpu/softfloat.c:4038:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#175: FILE: fpu/softfloat.c:4038:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#176: FILE: fpu/softfloat.c:4039:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited before that close parenthesis ')'
#176: FILE: fpu/softfloat.c:4039:
+    bSign = extractFloat16Sign( b );

WARNING: line over 80 characters
#179: FILE: fpu/softfloat.c:4042:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);

ERROR: spaces required around that '<<' (ctx:VxV)
#179: FILE: fpu/softfloat.c:4042:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);
                                                                     ^

ERROR: space prohibited after that open parenthesis '('
#179: FILE: fpu/softfloat.c:4042:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);

ERROR: space prohibited before that close parenthesis ')'
#179: FILE: fpu/softfloat.c:4042:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);

ERROR: trailing statements should be on next line
#179: FILE: fpu/softfloat.c:4042:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);

ERROR: braces {} are necessary for all arms of this statement
#179: FILE: fpu/softfloat.c:4042:
+    if ( aSign != bSign ) return aSign || ( (uint32_t) ( ( av | bv )<<1 ) == 0 
);
[...]

ERROR: space prohibited after that open parenthesis '('
#180: FILE: fpu/softfloat.c:4043:
+    return ( av == bv ) || ( aSign ^ ( av < bv ) );

ERROR: space prohibited before that close parenthesis ')'
#180: FILE: fpu/softfloat.c:4043:
+    return ( av == bv ) || ( aSign ^ ( av < bv ) );

ERROR: space prohibited after that open parenthesis '('
#198: FILE: fpu/softfloat.c:4061:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited before that close parenthesis ')'
#198: FILE: fpu/softfloat.c:4061:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited after that open parenthesis '('
#199: FILE: fpu/softfloat.c:4062:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited before that close parenthesis ')'
#199: FILE: fpu/softfloat.c:4062:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited after that open parenthesis '('
#207: FILE: fpu/softfloat.c:4070:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#207: FILE: fpu/softfloat.c:4070:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#208: FILE: fpu/softfloat.c:4071:
+    bSign = extractFloat16Sign( b );

ERROR: space prohibited before that close parenthesis ')'
#208: FILE: fpu/softfloat.c:4071:
+    bSign = extractFloat16Sign( b );

WARNING: line over 80 characters
#211: FILE: fpu/softfloat.c:4074:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);

ERROR: spaces required around that '<<' (ctx:VxV)
#211: FILE: fpu/softfloat.c:4074:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);
                                                                     ^

ERROR: space prohibited after that open parenthesis '('
#211: FILE: fpu/softfloat.c:4074:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);

ERROR: space prohibited before that close parenthesis ')'
#211: FILE: fpu/softfloat.c:4074:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);

ERROR: trailing statements should be on next line
#211: FILE: fpu/softfloat.c:4074:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);

ERROR: braces {} are necessary for all arms of this statement
#211: FILE: fpu/softfloat.c:4074:
+    if ( aSign != bSign ) return aSign && ( (uint32_t) ( ( av | bv )<<1 ) != 0 
);
[...]

ERROR: space prohibited after that open parenthesis '('
#212: FILE: fpu/softfloat.c:4075:
+    return ( av != bv ) && ( aSign ^ ( av < bv ) );

ERROR: space prohibited before that close parenthesis ')'
#212: FILE: fpu/softfloat.c:4075:
+    return ( av != bv ) && ( aSign ^ ( av < bv ) );

ERROR: space prohibited after that open parenthesis '('
#228: FILE: fpu/softfloat.c:4091:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited before that close parenthesis ')'
#228: FILE: fpu/softfloat.c:4091:
+    if (    ( ( extractFloat16Exp( a ) == 0x1F ) && extractFloat16Frac( a ) )

ERROR: space prohibited after that open parenthesis '('
#229: FILE: fpu/softfloat.c:4092:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

ERROR: space prohibited before that close parenthesis ')'
#229: FILE: fpu/softfloat.c:4092:
+         || ( ( extractFloat16Exp( b ) == 0x1F ) && extractFloat16Frac( b ) )

total: 84 errors, 4 warnings, 236 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 21/30: target/arm/translate-a64: add FP16 2-reg misc compare 
(zero)...
Checking PATCH 22/30: target/arm/translate-a64.c: add FP16 FAGCT to AdvSIMD 3 
Same...
Checking PATCH 23/30: softfloat: add float16_rem and float16_muladd (!CHECK)...
ERROR: space prohibited after that open parenthesis '('
#100: FILE: fpu/softfloat.c:3905:
+    aSig = extractFloat32Frac( a );

ERROR: space prohibited before that close parenthesis ')'
#100: FILE: fpu/softfloat.c:3905:
+    aSig = extractFloat32Frac( a );

ERROR: space prohibited after that open parenthesis '('
#101: FILE: fpu/softfloat.c:3906:
+    aExp = extractFloat32Exp( a );

ERROR: space prohibited before that close parenthesis ')'
#101: FILE: fpu/softfloat.c:3906:
+    aExp = extractFloat32Exp( a );

ERROR: space prohibited after that open parenthesis '('
#102: FILE: fpu/softfloat.c:3907:
+    aSign = extractFloat32Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#102: FILE: fpu/softfloat.c:3907:
+    aSign = extractFloat32Sign( a );

ERROR: space prohibited after that open parenthesis '('
#103: FILE: fpu/softfloat.c:3908:
+    bSig = extractFloat32Frac( b );

ERROR: space prohibited before that close parenthesis ')'
#103: FILE: fpu/softfloat.c:3908:
+    bSig = extractFloat32Frac( b );

ERROR: space prohibited after that open parenthesis '('
#104: FILE: fpu/softfloat.c:3909:
+    bExp = extractFloat32Exp( b );

ERROR: space prohibited before that close parenthesis ')'
#104: FILE: fpu/softfloat.c:3909:
+    bExp = extractFloat32Exp( b );

ERROR: space prohibited after that open parenthesis '('
#105: FILE: fpu/softfloat.c:3910:
+    if ( aExp == 0xFF ) {

ERROR: space prohibited before that close parenthesis ')'
#105: FILE: fpu/softfloat.c:3910:
+    if ( aExp == 0xFF ) {

ERROR: space prohibited after that open parenthesis '('
#106: FILE: fpu/softfloat.c:3911:
+        if ( aSig || ( ( bExp == 0xFF ) && bSig ) ) {

ERROR: space prohibited before that close parenthesis ')'
#106: FILE: fpu/softfloat.c:3911:
+        if ( aSig || ( ( bExp == 0xFF ) && bSig ) ) {

ERROR: space prohibited after that open parenthesis '('
#112: FILE: fpu/softfloat.c:3917:
+    if ( bExp == 0xFF ) {

ERROR: space prohibited before that close parenthesis ')'
#112: FILE: fpu/softfloat.c:3917:
+    if ( bExp == 0xFF ) {

ERROR: space prohibited after that open parenthesis '('
#118: FILE: fpu/softfloat.c:3923:
+    if ( bExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#118: FILE: fpu/softfloat.c:3923:
+    if ( bExp == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#119: FILE: fpu/softfloat.c:3924:
+        if ( bSig == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#119: FILE: fpu/softfloat.c:3924:
+        if ( bSig == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#123: FILE: fpu/softfloat.c:3928:
+        normalizeFloat32Subnormal( bSig, &bExp, &bSig );

ERROR: space prohibited before that close parenthesis ')'
#123: FILE: fpu/softfloat.c:3928:
+        normalizeFloat32Subnormal( bSig, &bExp, &bSig );

ERROR: space prohibited after that open parenthesis '('
#125: FILE: fpu/softfloat.c:3930:
+    if ( aExp == 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#125: FILE: fpu/softfloat.c:3930:
+    if ( aExp == 0 ) {

ERROR: space prohibited after that open parenthesis '('
#126: FILE: fpu/softfloat.c:3931:
+        if ( aSig == 0 ) return a;

ERROR: space prohibited before that close parenthesis ')'
#126: FILE: fpu/softfloat.c:3931:
+        if ( aSig == 0 ) return a;

ERROR: trailing statements should be on next line
#126: FILE: fpu/softfloat.c:3931:
+        if ( aSig == 0 ) return a;

ERROR: braces {} are necessary for all arms of this statement
#126: FILE: fpu/softfloat.c:3931:
+        if ( aSig == 0 ) return a;
[...]

ERROR: space prohibited after that open parenthesis '('
#127: FILE: fpu/softfloat.c:3932:
+        normalizeFloat32Subnormal( aSig, &aExp, &aSig );

ERROR: space prohibited before that close parenthesis ')'
#127: FILE: fpu/softfloat.c:3932:
+        normalizeFloat32Subnormal( aSig, &aExp, &aSig );

ERROR: space prohibited after that open parenthesis '('
#132: FILE: fpu/softfloat.c:3937:
+    if ( expDiff < 32 ) {

ERROR: space prohibited before that close parenthesis ')'
#132: FILE: fpu/softfloat.c:3937:
+    if ( expDiff < 32 ) {

ERROR: space prohibited after that open parenthesis '('
#135: FILE: fpu/softfloat.c:3940:
+        if ( expDiff < 0 ) {

ERROR: space prohibited before that close parenthesis ')'
#135: FILE: fpu/softfloat.c:3940:
+        if ( expDiff < 0 ) {

ERROR: space prohibited after that open parenthesis '('
#136: FILE: fpu/softfloat.c:3941:
+            if ( expDiff < -1 ) return a;

ERROR: space prohibited before that close parenthesis ')'
#136: FILE: fpu/softfloat.c:3941:
+            if ( expDiff < -1 ) return a;

ERROR: trailing statements should be on next line
#136: FILE: fpu/softfloat.c:3941:
+            if ( expDiff < -1 ) return a;

ERROR: braces {} are necessary for all arms of this statement
#136: FILE: fpu/softfloat.c:3941:
+            if ( expDiff < -1 ) return a;
[...]

ERROR: space prohibited after that open parenthesis '('
#139: FILE: fpu/softfloat.c:3944:
+        q = ( bSig <= aSig );

ERROR: space prohibited before that close parenthesis ')'
#139: FILE: fpu/softfloat.c:3944:
+        q = ( bSig <= aSig );

ERROR: space prohibited after that open parenthesis '('
#140: FILE: fpu/softfloat.c:3945:
+        if ( q ) aSig -= bSig;

ERROR: space prohibited before that close parenthesis ')'
#140: FILE: fpu/softfloat.c:3945:
+        if ( q ) aSig -= bSig;

ERROR: trailing statements should be on next line
#140: FILE: fpu/softfloat.c:3945:
+        if ( q ) aSig -= bSig;

ERROR: braces {} are necessary for all arms of this statement
#140: FILE: fpu/softfloat.c:3945:
+        if ( q ) aSig -= bSig;
[...]

ERROR: space prohibited after that open parenthesis '('
#141: FILE: fpu/softfloat.c:3946:
+        if ( 0 < expDiff ) {

ERROR: space prohibited before that close parenthesis ')'
#141: FILE: fpu/softfloat.c:3946:
+        if ( 0 < expDiff ) {

ERROR: spaces required around that '<<' (ctx:VxV)
#142: FILE: fpu/softfloat.c:3947:
+            q = ( ( (uint64_t) aSig )<<32 ) / bSig;
                                      ^

ERROR: space prohibited after that open parenthesis '('
#142: FILE: fpu/softfloat.c:3947:
+            q = ( ( (uint64_t) aSig )<<32 ) / bSig;

ERROR: space prohibited before that close parenthesis ')'
#142: FILE: fpu/softfloat.c:3947:
+            q = ( ( (uint64_t) aSig )<<32 ) / bSig;

ERROR: spaces required around that '>>' (ctx:VxV)
#145: FILE: fpu/softfloat.c:3950:
+            aSig = ( ( aSig>>1 )<<( expDiff - 1 ) ) - bSig * q;
                            ^

ERROR: spaces required around that '<<' (ctx:VxV)
#145: FILE: fpu/softfloat.c:3950:
+            aSig = ( ( aSig>>1 )<<( expDiff - 1 ) ) - bSig * q;
                                 ^

ERROR: space prohibited after that open parenthesis '('
#145: FILE: fpu/softfloat.c:3950:
+            aSig = ( ( aSig>>1 )<<( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited before that close parenthesis ')'
#145: FILE: fpu/softfloat.c:3950:
+            aSig = ( ( aSig>>1 )<<( expDiff - 1 ) ) - bSig * q;

ERROR: else should follow close brace '}'
#147: FILE: fpu/softfloat.c:3952:
+        }
+        else {

ERROR: else should follow close brace '}'
#152: FILE: fpu/softfloat.c:3957:
+    }
+    else {

ERROR: space prohibited after that open parenthesis '('
#153: FILE: fpu/softfloat.c:3958:
+        if ( bSig <= aSig ) aSig -= bSig;

ERROR: space prohibited before that close parenthesis ')'
#153: FILE: fpu/softfloat.c:3958:
+        if ( bSig <= aSig ) aSig -= bSig;

ERROR: trailing statements should be on next line
#153: FILE: fpu/softfloat.c:3958:
+        if ( bSig <= aSig ) aSig -= bSig;

ERROR: braces {} are necessary for all arms of this statement
#153: FILE: fpu/softfloat.c:3958:
+        if ( bSig <= aSig ) aSig -= bSig;
[...]

ERROR: spaces required around that '<<' (ctx:VxV)
#154: FILE: fpu/softfloat.c:3959:
+        aSig64 = ( (uint64_t) aSig )<<40;
                                     ^

ERROR: space prohibited after that open parenthesis '('
#154: FILE: fpu/softfloat.c:3959:
+        aSig64 = ( (uint64_t) aSig )<<40;

ERROR: space prohibited before that close parenthesis ')'
#154: FILE: fpu/softfloat.c:3959:
+        aSig64 = ( (uint64_t) aSig )<<40;

ERROR: spaces required around that '<<' (ctx:VxV)
#155: FILE: fpu/softfloat.c:3960:
+        bSig64 = ( (uint64_t) bSig )<<40;
                                     ^

ERROR: space prohibited after that open parenthesis '('
#155: FILE: fpu/softfloat.c:3960:
+        bSig64 = ( (uint64_t) bSig )<<40;

ERROR: space prohibited before that close parenthesis ')'
#155: FILE: fpu/softfloat.c:3960:
+        bSig64 = ( (uint64_t) bSig )<<40;

ERROR: space prohibited after that open parenthesis '('
#157: FILE: fpu/softfloat.c:3962:
+        while ( 0 < expDiff ) {

ERROR: space prohibited before that close parenthesis ')'
#157: FILE: fpu/softfloat.c:3962:
+        while ( 0 < expDiff ) {

ERROR: space prohibited after that open parenthesis '('
#158: FILE: fpu/softfloat.c:3963:
+            q64 = estimateDiv128To64( aSig64, 0, bSig64 );

ERROR: space prohibited before that close parenthesis ')'
#158: FILE: fpu/softfloat.c:3963:
+            q64 = estimateDiv128To64( aSig64, 0, bSig64 );

ERROR: space prohibited after that open parenthesis '('
#159: FILE: fpu/softfloat.c:3964:
+            q64 = ( 2 < q64 ) ? q64 - 2 : 0;

ERROR: space prohibited before that close parenthesis ')'
#159: FILE: fpu/softfloat.c:3964:
+            q64 = ( 2 < q64 ) ? q64 - 2 : 0;

ERROR: space prohibited after that '-' (ctx:WxW)
#160: FILE: fpu/softfloat.c:3965:
+            aSig64 = - ( ( bSig * q64 )<<38 );
                      ^

ERROR: spaces required around that '<<' (ctx:VxV)
#160: FILE: fpu/softfloat.c:3965:
+            aSig64 = - ( ( bSig * q64 )<<38 );
                                        ^

ERROR: space prohibited after that open parenthesis '('
#160: FILE: fpu/softfloat.c:3965:
+            aSig64 = - ( ( bSig * q64 )<<38 );

ERROR: space prohibited before that close parenthesis ')'
#160: FILE: fpu/softfloat.c:3965:
+            aSig64 = - ( ( bSig * q64 )<<38 );

ERROR: space prohibited after that open parenthesis '('
#164: FILE: fpu/softfloat.c:3969:
+        q64 = estimateDiv128To64( aSig64, 0, bSig64 );

ERROR: space prohibited before that close parenthesis ')'
#164: FILE: fpu/softfloat.c:3969:
+        q64 = estimateDiv128To64( aSig64, 0, bSig64 );

ERROR: space prohibited after that open parenthesis '('
#165: FILE: fpu/softfloat.c:3970:
+        q64 = ( 2 < q64 ) ? q64 - 2 : 0;

ERROR: space prohibited before that close parenthesis ')'
#165: FILE: fpu/softfloat.c:3970:
+        q64 = ( 2 < q64 ) ? q64 - 2 : 0;

ERROR: spaces required around that '>>' (ctx:VxV)
#166: FILE: fpu/softfloat.c:3971:
+        q = q64>>( 64 - expDiff );
                ^

ERROR: space prohibited after that open parenthesis '('
#166: FILE: fpu/softfloat.c:3971:
+        q = q64>>( 64 - expDiff );

ERROR: space prohibited before that close parenthesis ')'
#166: FILE: fpu/softfloat.c:3971:
+        q = q64>>( 64 - expDiff );

ERROR: spaces required around that '>>' (ctx:VxV)
#168: FILE: fpu/softfloat.c:3973:
+        aSig = ( ( aSig64>>33 )<<( expDiff - 1 ) ) - bSig * q;
                          ^

ERROR: spaces required around that '<<' (ctx:VxV)
#168: FILE: fpu/softfloat.c:3973:
+        aSig = ( ( aSig64>>33 )<<( expDiff - 1 ) ) - bSig * q;
                                ^

ERROR: space prohibited after that open parenthesis '('
#168: FILE: fpu/softfloat.c:3973:
+        aSig = ( ( aSig64>>33 )<<( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited before that close parenthesis ')'
#168: FILE: fpu/softfloat.c:3973:
+        aSig = ( ( aSig64>>33 )<<( expDiff - 1 ) ) - bSig * q;

ERROR: space prohibited after that open parenthesis '('
#174: FILE: fpu/softfloat.c:3979:
+    } while ( 0 <= (int32_t) aSig );

ERROR: space prohibited before that close parenthesis ')'
#174: FILE: fpu/softfloat.c:3979:
+    } while ( 0 <= (int32_t) aSig );

ERROR: space prohibited after that open parenthesis '('
#176: FILE: fpu/softfloat.c:3981:
+    if ( ( sigMean < 0 ) || ( ( sigMean == 0 ) && ( q & 1 ) ) ) {

ERROR: space prohibited before that close parenthesis ')'
#176: FILE: fpu/softfloat.c:3981:
+    if ( ( sigMean < 0 ) || ( ( sigMean == 0 ) && ( q & 1 ) ) ) {

ERROR: space prohibited after that open parenthesis '('
#179: FILE: fpu/softfloat.c:3984:
+    zSign = ( (int32_t) aSig < 0 );

ERROR: space prohibited before that close parenthesis ')'
#179: FILE: fpu/softfloat.c:3984:
+    zSign = ( (int32_t) aSig < 0 );

ERROR: space prohibited after that '-' (ctx:WxW)
#180: FILE: fpu/softfloat.c:3985:
+    if ( zSign ) aSig = - aSig;
                         ^

ERROR: space prohibited after that open parenthesis '('
#180: FILE: fpu/softfloat.c:3985:
+    if ( zSign ) aSig = - aSig;

ERROR: space prohibited before that close parenthesis ')'
#180: FILE: fpu/softfloat.c:3985:
+    if ( zSign ) aSig = - aSig;

ERROR: trailing statements should be on next line
#180: FILE: fpu/softfloat.c:3985:
+    if ( zSign ) aSig = - aSig;

ERROR: braces {} are necessary for all arms of this statement
#180: FILE: fpu/softfloat.c:3985:
+    if ( zSign ) aSig = - aSig;
[...]

WARNING: line over 80 characters
#296: FILE: fpu/softfloat.c:4101:
+            return roundAndPackFloat16(cSign ^ signflip, cExp, cSig, true, 
status);

total: 97 errors, 1 warnings, 399 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 24/30: disas_simd_indexed: support half-precision operations...
Checking PATCH 25/30: softfloat: float16_round_to_int...
ERROR: space prohibited after that open parenthesis '('
#36: FILE: fpu/softfloat.c:3550:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited before that close parenthesis ')'
#36: FILE: fpu/softfloat.c:3550:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited after that open parenthesis '('
#37: FILE: fpu/softfloat.c:3551:
+    if ( 0x19 <= aExp ) {

ERROR: space prohibited before that close parenthesis ')'
#37: FILE: fpu/softfloat.c:3551:
+    if ( 0x19 <= aExp ) {

ERROR: space prohibited after that open parenthesis '('
#38: FILE: fpu/softfloat.c:3552:
+        if ( ( aExp == 0x1F ) && extractFloat16Frac( a ) ) {

ERROR: space prohibited before that close parenthesis ')'
#38: FILE: fpu/softfloat.c:3552:
+        if ( ( aExp == 0x1F ) && extractFloat16Frac( a ) ) {

ERROR: space prohibited after that open parenthesis '('
#43: FILE: fpu/softfloat.c:3557:
+    if ( aExp <= 0xE ) {

ERROR: space prohibited before that close parenthesis ')'
#43: FILE: fpu/softfloat.c:3557:
+    if ( aExp <= 0xE ) {

ERROR: spaces required around that '<<' (ctx:VxV)
#44: FILE: fpu/softfloat.c:3558:
+        if ( (uint16_t) ( float16_val(a)<<1 ) == 0 ) return a;
                                         ^

ERROR: space prohibited after that open parenthesis '('
#44: FILE: fpu/softfloat.c:3558:
+        if ( (uint16_t) ( float16_val(a)<<1 ) == 0 ) return a;

ERROR: space prohibited before that close parenthesis ')'
#44: FILE: fpu/softfloat.c:3558:
+        if ( (uint16_t) ( float16_val(a)<<1 ) == 0 ) return a;

ERROR: trailing statements should be on next line
#44: FILE: fpu/softfloat.c:3558:
+        if ( (uint16_t) ( float16_val(a)<<1 ) == 0 ) return a;

ERROR: braces {} are necessary for all arms of this statement
#44: FILE: fpu/softfloat.c:3558:
+        if ( (uint16_t) ( float16_val(a)<<1 ) == 0 ) return a;
[...]

ERROR: space prohibited after that open parenthesis '('
#46: FILE: fpu/softfloat.c:3560:
+        aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#46: FILE: fpu/softfloat.c:3560:
+        aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#49: FILE: fpu/softfloat.c:3563:
+            if ( ( aExp == 0xE ) && extractFloat16Frac( a ) ) {

ERROR: space prohibited before that close parenthesis ')'
#49: FILE: fpu/softfloat.c:3563:
+            if ( ( aExp == 0xE ) && extractFloat16Frac( a ) ) {

ERROR: space prohibited after that open parenthesis '('
#50: FILE: fpu/softfloat.c:3564:
+                return packFloat16( aSign, 0xF, 0 );

ERROR: space prohibited before that close parenthesis ')'
#50: FILE: fpu/softfloat.c:3564:
+                return packFloat16( aSign, 0xF, 0 );

ERROR: space prohibited after that open parenthesis '('
#64: FILE: fpu/softfloat.c:3578:
+        return packFloat16( aSign, 0, 0 );

ERROR: space prohibited before that close parenthesis ')'
#64: FILE: fpu/softfloat.c:3578:
+        return packFloat16( aSign, 0, 0 );

ERROR: spaces required around that '>>' (ctx:VxV)
#72: FILE: fpu/softfloat.c:3586:
+        z += lastBitMask>>1;
                         ^

ERROR: space prohibited after that '~' (ctx:WxW)
#95: FILE: fpu/softfloat.c:3609:
+    z &= ~ roundBitsMask;
          ^

total: 23 errors, 0 warnings, 95 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 26/30: tests/test-softfloat: add a simple test framework...
WARNING: line over 80 characters
#88: FILE: tests/test-softfloat.c:31:
+        { { .float_detect_tininess = 1, .float_rounding_mode = 2}, 0x06b1, 
0x3c00, 0 },

WARNING: line over 80 characters
#89: FILE: tests/test-softfloat.c:32:
+        { { .float_detect_tininess = 1, .float_rounding_mode = 2}, 0x6966, 
0x6966, 0 },

WARNING: line over 80 characters
#90: FILE: tests/test-softfloat.c:33:
+        { { .float_detect_tininess = 1, .float_rounding_mode = 2}, 0x83c0, 
0x8000, 0 },

WARNING: line over 80 characters
#91: FILE: tests/test-softfloat.c:34:
+        { { .float_detect_tininess = 1, .float_rounding_mode = 2}, 0xa619, 
0x8000, 0 },

WARNING: line over 80 characters
#92: FILE: tests/test-softfloat.c:35:
+        { { .float_detect_tininess = 1, .float_rounding_mode = 2}, 0x9cf4, 
0x8000, 0 },

WARNING: line over 80 characters
#93: FILE: tests/test-softfloat.c:36:
+        { { .float_detect_tininess = 1, .float_rounding_mode = 2}, 0xee11, 
0xee11, 0 },

WARNING: line over 80 characters
#94: FILE: tests/test-softfloat.c:37:
+        { { .float_detect_tininess = 1, .float_rounding_mode = 2}, 0xee5c, 
0xee5c, 0 },

WARNING: line over 80 characters
#95: FILE: tests/test-softfloat.c:38:
+        { { .float_detect_tininess = 1, .float_rounding_mode = 2}, 0x8004, 
0x8000, 0 }

total: 0 errors, 8 warnings, 84 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 27/30: target/arm/translate-a64.c: add FP16 FRINTP to 2 reg 
misc...
Checking PATCH 28/30: softfloat: float16_to_int16 conversion...
WARNING: line over 80 characters
#35: FILE: fpu/softfloat.c:146:
+static int16_t roundAndPackInt16(flag zSign, uint32_t absZ, float_status 
*status)

ERROR: space prohibited after that open parenthesis '('
#43: FILE: fpu/softfloat.c:154:
+    roundNearestEven = ( roundingMode == float_round_nearest_even );

ERROR: space prohibited before that close parenthesis ')'
#43: FILE: fpu/softfloat.c:154:
+    roundNearestEven = ( roundingMode == float_round_nearest_even );

ERROR: spaces required around that '>>' (ctx:VxV)
#64: FILE: fpu/softfloat.c:175:
+    absZ = ( absZ + roundIncrement )>>7;
                                     ^

ERROR: space prohibited after that open parenthesis '('
#64: FILE: fpu/softfloat.c:175:
+    absZ = ( absZ + roundIncrement )>>7;

ERROR: space prohibited before that close parenthesis ')'
#64: FILE: fpu/softfloat.c:175:
+    absZ = ( absZ + roundIncrement )>>7;

ERROR: space prohibited after that '~' (ctx:WxW)
#65: FILE: fpu/softfloat.c:176:
+    absZ &= ~ ( ( ( roundBits ^ 0x40 ) == 0 ) & roundNearestEven );
             ^

ERROR: space prohibited after that open parenthesis '('
#65: FILE: fpu/softfloat.c:176:
+    absZ &= ~ ( ( ( roundBits ^ 0x40 ) == 0 ) & roundNearestEven );

ERROR: space prohibited before that close parenthesis ')'
#65: FILE: fpu/softfloat.c:176:
+    absZ &= ~ ( ( ( roundBits ^ 0x40 ) == 0 ) & roundNearestEven );

ERROR: space prohibited after that '-' (ctx:WxW)
#67: FILE: fpu/softfloat.c:178:
+    if ( zSign ) z = - z;
                      ^

ERROR: space prohibited after that open parenthesis '('
#67: FILE: fpu/softfloat.c:178:
+    if ( zSign ) z = - z;

ERROR: space prohibited before that close parenthesis ')'
#67: FILE: fpu/softfloat.c:178:
+    if ( zSign ) z = - z;

ERROR: trailing statements should be on next line
#67: FILE: fpu/softfloat.c:178:
+    if ( zSign ) z = - z;

ERROR: braces {} are necessary for all arms of this statement
#67: FILE: fpu/softfloat.c:178:
+    if ( zSign ) z = - z;
[...]

ERROR: spaces required around that '>>' (ctx:VxV)
#69: FILE: fpu/softfloat.c:180:
+    if ( ( absZ>>16 ) || ( z && ( ( z < 0 ) ^ zSign ) ) ) {
                ^

ERROR: space prohibited after that open parenthesis '('
#69: FILE: fpu/softfloat.c:180:
+    if ( ( absZ>>16 ) || ( z && ( ( z < 0 ) ^ zSign ) ) ) {

ERROR: space prohibited before that close parenthesis ')'
#69: FILE: fpu/softfloat.c:180:
+    if ( ( absZ>>16 ) || ( z && ( ( z < 0 ) ^ zSign ) ) ) {

ERROR: space prohibited after that open parenthesis '('
#105: FILE: fpu/softfloat.c:4585:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited before that close parenthesis ')'
#105: FILE: fpu/softfloat.c:4585:
+    aSig = extractFloat16Frac( a );

ERROR: space prohibited after that open parenthesis '('
#106: FILE: fpu/softfloat.c:4586:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited before that close parenthesis ')'
#106: FILE: fpu/softfloat.c:4586:
+    aExp = extractFloat16Exp( a );

ERROR: space prohibited after that open parenthesis '('
#107: FILE: fpu/softfloat.c:4587:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited before that close parenthesis ')'
#107: FILE: fpu/softfloat.c:4587:
+    aSign = extractFloat16Sign( a );

ERROR: space prohibited after that open parenthesis '('
#108: FILE: fpu/softfloat.c:4588:
+    if ( ( aExp == 0x1F ) && aSig ) aSign = 0;

ERROR: space prohibited before that close parenthesis ')'
#108: FILE: fpu/softfloat.c:4588:
+    if ( ( aExp == 0x1F ) && aSig ) aSign = 0;

ERROR: trailing statements should be on next line
#108: FILE: fpu/softfloat.c:4588:
+    if ( ( aExp == 0x1F ) && aSig ) aSign = 0;

ERROR: braces {} are necessary for all arms of this statement
#108: FILE: fpu/softfloat.c:4588:
+    if ( ( aExp == 0x1F ) && aSig ) aSign = 0;
[...]

ERROR: space prohibited after that open parenthesis '('
#109: FILE: fpu/softfloat.c:4589:
+    if ( aExp ) aSig |= 0x0400; /* implicit bit */

ERROR: space prohibited before that close parenthesis ')'
#109: FILE: fpu/softfloat.c:4589:
+    if ( aExp ) aSig |= 0x0400; /* implicit bit */

ERROR: trailing statements should be on next line
#109: FILE: fpu/softfloat.c:4589:
+    if ( aExp ) aSig |= 0x0400; /* implicit bit */

ERROR: braces {} are necessary for all arms of this statement
#109: FILE: fpu/softfloat.c:4589:
+    if ( aExp ) aSig |= 0x0400; /* implicit bit */
[...]

ERROR: space prohibited after that open parenthesis '('
#124: FILE: fpu/softfloat.c:4604:
+        shift32RightJamming( aSig, 3 - aExp, &aSig );

ERROR: space prohibited before that close parenthesis ')'
#124: FILE: fpu/softfloat.c:4604:
+        shift32RightJamming( aSig, 3 - aExp, &aSig );

total: 32 errors, 1 warnings, 117 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 29/30: tests/test-softfloat: add f16_to_int16 conversion test...
Checking PATCH 30/30: target/arm/translate-a64.c: add FP16 FCVTPS to 2 reg 
misc...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-devel] [RFC PATCH 21/30] target/arm/translate-a64: add FP16 2-reg misc compare (zero), (continued)
- [Qemu-devel] [RFC PATCH 21/30] target/arm/translate-a64: add FP16 2-reg misc compare (zero), Alex Bennée, 2017/10/13
  - Re: [Qemu-devel] [RFC PATCH 21/30] target/arm/translate-a64: add FP16 2-reg misc compare (zero), Richard Henderson, 2017/10/16
- [Qemu-devel] [RFC PATCH 24/30] disas_simd_indexed: support half-precision operations, Alex Bennée, 2017/10/13
- [Qemu-devel] [RFC PATCH 14/30] softfloat: 16 bit helpers for shr, clz and rounding and packing, Alex Bennée, 2017/10/13
  - Re: [Qemu-devel] [RFC PATCH 14/30] softfloat: 16 bit helpers for shr, clz and rounding and packing, Richard Henderson, 2017/10/15
    - Re: [Qemu-devel] [RFC PATCH 14/30] softfloat: 16 bit helpers for shr, clz and rounding and packing, Alex Bennée, 2017/10/16
- [Qemu-devel] [RFC PATCH 19/30] Fix mask for AdvancedSIMD 2 reg misc, Alex Bennée, 2017/10/13
  - Re: [Qemu-devel] [RFC PATCH 19/30] Fix mask for AdvancedSIMD 2 reg misc, Richard Henderson, 2017/10/16
- [Qemu-devel] [RFC PATCH 16/30] target/arm/translate-a64.c: add FP16 FADD/FMUL/FDIV to AdvSIMD 3 Same (!sub), Alex Bennée, 2017/10/13
  - Re: [Qemu-devel] [RFC PATCH 16/30] target/arm/translate-a64.c: add FP16 FADD/FMUL/FDIV to AdvSIMD 3 Same (!sub), Richard Henderson, 2017/10/16
- Re: [Qemu-devel] [RFC PATCH 00/30] v8.2 half-precision support (work-in-progress), no-reply <=
- Re: [Qemu-devel] [RFC PATCH 00/30] v8.2 half-precision support (work-in-progress), no-reply, 2017/10/14
- Re: [Qemu-devel] [RFC PATCH 00/30] v8.2 half-precision support (work-in-progress), Richard Henderson, 2017/10/16
Prev by Date: [Qemu-devel] [RFC PATCH 16/30] target/arm/translate-a64.c: add FP16 FADD/FMUL/FDIV to AdvSIMD 3 Same (!sub)
Next by Date: Re: [Qemu-devel] host physical address width issues/questions for x86_64
Previous by thread: Re: [Qemu-devel] [RFC PATCH 16/30] target/arm/translate-a64.c: add FP16 FADD/FMUL/FDIV to AdvSIMD 3 Same (!sub)
Next by thread: Re: [Qemu-devel] [RFC PATCH 00/30] v8.2 half-precision support (work-in-progress)
Index(es):
- Date
- Thread