[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/9] nbd/server: refactor nbd_co_send_simple_reply pa
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PULL 7/9] nbd/server: refactor nbd_co_send_simple_reply parameters |
Date: |
Sat, 14 Oct 2017 19:40:31 -0500 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
Pass client and buffer (*data) parameters directly, to make the function
consistent with further structured reply sending functions.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
---
nbd/server.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/nbd/server.c b/nbd/server.c
index 06aeadcfbb..3fcc3d3c7c 100644
--- a/nbd/server.c
+++ b/nbd/server.c
@@ -1196,12 +1196,13 @@ static inline void set_be_simple_reply(NBDSimpleReply
*reply, uint64_t error,
stq_be_p(&reply->handle, handle);
}
-static int nbd_co_send_simple_reply(NBDRequestData *req,
+static int nbd_co_send_simple_reply(NBDClient *client,
uint64_t handle,
uint32_t error,
- int len, Error **errp)
+ void *data,
+ size_t len,
+ Error **errp)
{
- NBDClient *client = req->client;
NBDSimpleReply simple_reply;
int nbd_err = system_errno_to_nbd_errno(error);
int ret;
@@ -1220,7 +1221,7 @@ static int nbd_co_send_simple_reply(NBDRequestData *req,
qio_channel_set_cork(client->ioc, true);
ret = nbd_write(client->ioc, &simple_reply, sizeof(simple_reply),
errp);
if (ret == 0) {
- ret = nbd_write(client->ioc, req->data, len, errp);
+ ret = nbd_write(client->ioc, data, len, errp);
if (ret < 0) {
ret = -EIO;
}
@@ -1447,9 +1448,9 @@ reply:
local_err = NULL;
}
- if (nbd_co_send_simple_reply(req, request.handle,
+ if (nbd_co_send_simple_reply(req->client, request.handle,
ret < 0 ? -ret : 0,
- reply_data_len, &local_err) < 0)
+ req->data, reply_data_len, &local_err) < 0)
{
error_prepend(&local_err, "Failed to send reply: ");
goto disconnect;
--
2.13.6
- [Qemu-devel] [PULL 0/9] NBD patches through 14 Oct, Eric Blake, 2017/10/14
- [Qemu-devel] [PULL 1/9] NBD: use g_new() family of functions, Eric Blake, 2017/10/14
- [Qemu-devel] [PULL 2/9] block/nbd-client: assert qiov len once in nbd_co_request, Eric Blake, 2017/10/14
- [Qemu-devel] [PULL 3/9] block/nbd-client: refactor nbd_co_receive_reply, Eric Blake, 2017/10/14
- [Qemu-devel] [PULL 4/9] nbd: rename some simple-request related objects to be _simple_, Eric Blake, 2017/10/14
- [Qemu-devel] [PULL 5/9] nbd/server: structurize simple reply header sending, Eric Blake, 2017/10/14
- [Qemu-devel] [PULL 7/9] nbd/server: refactor nbd_co_send_simple_reply parameters,
Eric Blake <=
- [Qemu-devel] [PULL 6/9] nbd/server: do not use NBDReply structure, Eric Blake, 2017/10/14
- [Qemu-devel] [PULL 8/9] nbd/server: simplify reply transmission, Eric Blake, 2017/10/14
- [Qemu-devel] [PULL 9/9] nbd: header constants indenting, Eric Blake, 2017/10/14
- Re: [Qemu-devel] [PULL 0/9] NBD patches through 14 Oct, Peter Maydell, 2017/10/16