[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests |
Date: |
Mon, 16 Oct 2017 17:29:10 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
* Juan Quintela (address@hidden) wrote:
> For some reason, compression is not working at the moment, test is
> disabled until I found why.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> tests/migration-test.c | 51
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index f0734e4ba0..a8abc3d007 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -621,6 +621,54 @@ static void test_xbzrle_unix(void)
> g_free(uri);
> }
>
> +static void test_compress(const char *uri)
> +{
> + QTestState *from, *to;
> +
> + test_migrate_start(&from, &to, uri);
> +
> + /* We want to pick a speed slow enough that the test completes
> + * quickly, but that it doesn't complete precopy even on a slow
> + * machine, so also set the downtime.
> + */
> + /* 100 ms */
> + migrate_set_parameter(from, "downtime-limit", "100");
> + /* 1MB/s slow*/
> + migrate_set_parameter(from, "max-bandwidth", "100000000");
> +
> + migrate_set_parameter(from, "compress-threads", "4");
> + migrate_set_parameter(from, "decompress-threads", "3");
Should that be 'to' ?
I worry about having this many threads in a loaded test environment.
Dave
> + migrate_set_capability(from, "compress", "true");
> + migrate_set_capability(to, "compress", "true");
> + /* Wait for the first serial output from the source */
> + wait_for_serial("src_serial");
> +
> + migrate(from, uri);
> +
> + wait_for_migration_pass(from);
> +
> + /* 1GB/s now it should converge */
> + migrate_set_parameter(from, "max-bandwidth", "1000000000");
> +
> + if (!got_stop) {
> + qtest_qmp_eventwait(from, "STOP");
> + }
> + qtest_qmp_eventwait(to, "RESUME");
> +
> + wait_for_serial("dest_serial");
> + wait_for_migration_complete(from);
> +
> + test_migrate_end(from, to);
> +}
> +
> +static void test_compress_unix(void)
> +{
> + char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
> +
> + test_compress(uri);
> + g_free(uri);
> +}
>
> int main(int argc, char **argv)
> {
> @@ -641,6 +689,9 @@ int main(int argc, char **argv)
> qtest_add_func("/migration/precopy/tcp", test_precopy_tcp);
> qtest_add_func("/migration/deprecated/unix", test_deprecated_unix);
> qtest_add_func("/migration/xbzrle/unix", test_xbzrle_unix);
> + if (0) {
> + qtest_add_func("/migration/compress/unix", test_compress_unix);
> + }
>
> ret = g_test_run();
>
> --
> 2.13.5
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test, (continued)