qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small clea


From: Joe Clifford
Subject: Re: [Qemu-devel] [PATCH v1 0/7] kvm: slot handling fixes (and small cleanups)
Date: Tue, 17 Oct 2017 01:06:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 16/10/17 17:20, Paolo Bonzini wrote:
On 16/10/2017 16:42, David Hildenbrand wrote:
Hopefully this is the last bunch of fixes for the cleanup series.

1. log_start() was called before region_add(), which is wrong.
2. I messed up the calculation of the delta when aligning the ram address
    (maybe we should simply also use ROUND_UP there ...).
3. I think we could get log_start/log_stop/log_sync when we actually
    haven't registered a slot (due to trapping).
4. Some further cleanups

Available on: https://github.com/davidhildenbrand/qemu/commits/kvm_slot

@Joe, if you could retest, this would be great! I updated the branch.

David Hildenbrand (7):
   memory: call log_start after region_add
   kvm: fix alignment of ram address
   kvm: tolerate non-existing slot for log_start/log_stop/log_sync
   kvm: fix error message when failing to unregister slot
   kvm: region_add and region_del is not called on updates
   kvm: simplify kvm_align_section()
   memory: reuse section_from_flat_range()

  accel/kvm/kvm-all.c | 39 ++++++++++++++-------------------------
  memory.c            | 16 +++++-----------
  2 files changed, 19 insertions(+), 36 deletions(-)


Looks good!  I'll wait for testing results if they come soon.

Paolo


Hi,

I've pulled the updates from David's repo and tested the same branch (kvm_slot) and they work beautifully for me. Thanks for fixing this David!

Joe



reply via email to

[Prev in Thread] Current Thread [Next in Thread]