[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/1] qemu-iotests: Test backing_fmt with backing
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2/1] qemu-iotests: Test backing_fmt with backing node reference |
Date: |
Tue, 17 Oct 2017 16:44:08 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/17/2017 10:16 AM, Kevin Wolf wrote:
> Am 17.10.2017 um 17:11 hat Kevin Wolf geschrieben:
>> This changes test case 191 to include a backing image that has
>> backing_fmt set in the image file, but is referenced by node name in the
>> qemu command line.
>>
>> Signed-off-by: Kevin Wolf <address@hidden>
>> ---
>> tests/qemu-iotests/191 | 5 +++--
>> tests/qemu-iotests/191.out | 2 +-
>> 2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/191 b/tests/qemu-iotests/191
>> index ac2b88fd78..00202efd47 100755
>> --- a/tests/qemu-iotests/191
>> +++ b/tests/qemu-iotests/191
>> @@ -56,9 +56,10 @@ echo === Preparing and starting VM ===
>> echo
>>
>> TEST_IMG="${TEST_IMG}.base" _make_test_img $size
>> -TEST_IMG="${TEST_IMG}.mid" _make_test_img -b "${TEST_IMG}.base"
>> +IMGOPTS=$(_optstr_add "$IMGOPTS" "backing_fmt=$IMGFMT") \
>> + TEST_IMG="${TEST_IMG}.mid" _make_test_img -b "${TEST_IMG}.base" $size
>> _make_test_img -b "${TEST_IMG}.mid"
>> -TEST_IMG="${TEST_IMG}.ovl2" _make_test_img -b "${TEST_IMG}.mid"
>> +TEST_IMG="${TEST_IMG}.ovl2" _make_test_img -b "${TEST_IMG}.mid" $size
>
> Please pretend you don't see the addition of " $size" here, it's
> unnecessary and I'll remove it again.
As tweaked,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature