[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] qdev: store DeviceState's canonical path
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] qdev: store DeviceState's canonical path to use when unparenting |
|
Date: |
Wed, 18 Oct 2017 10:34:01 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 17/10/2017 07:45, David Gibson wrote:
>>
>> post_realize_fail:
>> + g_free(dev->canonical_path);
> Should dev->canonical_path be set to NULL on this failure path?
>
It should be fine because dev->pending_deleted_event can only become
true if dev->realized has ever been set to true. But it's certainly
cleaner to clear it, so I'll do the change.
Queued the series, thanks.
Paolo
signature.asc
Description: OpenPGP digital signature