[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] migration: Fix migrate_test_apply for mul
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] migration: Fix migrate_test_apply for multifd parameters |
Date: |
Wed, 18 Oct 2017 10:37:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> On Tue, Oct 10, 2017 at 08:15:33PM +0200, Juan Quintela wrote:
>> They were missing when introduced on the tree
>>
>> Signed-off-by: Juan Quintela <address@hidden>
>> ---
>> migration/migration.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/migration/migration.c b/migration/migration.c
>> index 98429dc843..fb62a639d8 100644
>> --- a/migration/migration.c
>> +++ b/migration/migration.c
>> @@ -865,6 +865,12 @@ static void
>> migrate_params_test_apply(MigrateSetParameters *params,
>> if (params->has_block_incremental) {
>> dest->block_incremental = params->block_incremental;
>> }
>
> (newline?)
I preffer without it.
At least in migration we have code with both approachs.
>
>> + if (params->has_x_multifd_channels) {
>> + dest->x_multifd_channels = params->x_multifd_channels;
>> + }
>
> (newline?)
>
>> + if (params->has_x_multifd_page_count) {
>> + dest->x_multifd_page_count = params->x_multifd_page_count;
>> + }
>> }
>>
>> static void migrate_params_apply(MigrateSetParameters *params)
>> --
>> 2.13.6
>>
>
> Reviewed-by: Peter Xu <address@hidden>
Thanks.
- [Qemu-devel] [PATCH 00/10] Make xbzrle_cache_size a migration parameter, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 01/10] migration: Fix migrate_test_apply for multifd parameters, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 02/10] migratiom: Remove max_item_age parameter, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 03/10] migration: Make cache size elements use the right types, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 04/10] migration: Move xbzrle cache resize error handling to xbzrle_cache_resize, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 05/10] migration: Make cache_init() take an error parameter, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 07/10] migration: Don't play games with the requested cache size, Juan Quintela, 2017/10/10
- [Qemu-devel] [PATCH 06/10] migration: Make sure that we pass the right cache size, Juan Quintela, 2017/10/10