|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v4 4/4] contrib/vhost-user-blk: introduce a vhost-user-blk sample application |
Date: | Thu, 19 Oct 2017 13:43:35 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 19/10/2017 07:24, Changpeng Liu wrote: > > +} > + > +static void > +vub_flush(VubReq *req) > +{ > + VubDev *vdev_blk = req->vdev_blk; > + > + if (vdev_blk->blk_fd) { > + fsync(vdev_blk->blk_fd); > + } > +} > + No need to check the file descriptor---vub_readv and vub_writev aren't checking it either. Also please use fdatasync instead of fsync. > +static uint64_t > +vub_get_features(VuDev *dev) > +{ > + return 1ull << VIRTIO_BLK_F_SIZE_MAX | > + 1ull << VIRTIO_BLK_F_SEG_MAX | > + 1ull << VIRTIO_BLK_F_TOPOLOGY | > + 1ull << VIRTIO_BLK_F_BLK_SIZE | > + 1ull << VIRTIO_F_VERSION_1 | > + 1ull << VHOST_USER_F_PROTOCOL_FEATURES; > +} VIRTIO_BLK_F_FLUSH is missing. Thanks, Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |