[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key n
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbers |
Date: |
Thu, 19 Oct 2017 10:18:18 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/19/2017 09:28 AM, Daniel P. Berrange wrote:
> Previously we enforced that all key events are using QKeyCodes
> at time they are sent:
>
> commit af07e5ff02ae6d4258fc5331007811d0b1c4d35a
> Author: Daniel P. Berrange <address@hidden>
> Date: Fri Sep 29 11:12:00 2017 +0100
>
> ui: convert key events to QKeyCodes immediately
>
> This commit forget to fix the code for the legacy 'sendkey'
> command which still accepts key numbers from the user, which
> then need converting to QKeyCodes
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> ui/input-legacy.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v1 0/9] Various fixes for input/ps2 handling, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbers, Daniel P. Berrange, 2017/10/19
- Re: [Qemu-devel] [PATCH v1 2/9] ui: fix crash with sendkey and raw key numbers,
Eric Blake <=
- [Qemu-devel] [PATCH v1 3/9] ui: use correct union field for key number, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 1/9] input: use hex in ps2 keycode trace events, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq), Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 5/9] ps2: fix scancodes sent for Shift/Ctrl+Print key combination, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 6/9] ps2: fix scancodess sent for Pause key in AT set 1, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 7/9] ps2: fix scancodes sent for Ctrl+Pause key combination, Daniel P. Berrange, 2017/10/19
- [Qemu-devel] [PATCH v1 8/9] ui: normalize the 'sysrq' key into the 'print' key, Daniel P. Berrange, 2017/10/19