[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] xen: link against xentoolcore
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] xen: link against xentoolcore |
Date: |
Thu, 19 Oct 2017 17:47:28 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Thu, Oct 19, 2017 at 05:38:10PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("Re: [PATCH 1/8] xen: link against xentoolcore"):
> > I don't think it is necessary to do anything in qemu. The linker should
> > find on its own the new libxentoolcore as long as an option
> > -Wl,-rpath-link= provide the right path to xentoolcore when building
> > qemu from xen.git. In other cases, the pkg-config files should be
> > enough (configure doesn't need to known about a new xentoolcore.pc
> > file).
>
> It seems that the build still works, without this patch but without
> the rest of my series too, because we end up passing
> -L/u/iwj/work/xen.git/tools/../tools/libs/toolcore
> -Wl,-rpath-link=/u/iwj/work/xen.git/tools/../tools/libs/toolcore
> (or similar) on the qemu link line. So when ld links against
> libxenstore (say) it finds that xenstore needs toolcore and finds
> toolcore in the relevant paths.
>
> We still need this patch for the rest of the series, though.
Of course, I was only arguing that this patch on its own is not usefull.
Do you need a signed-off-by or review-by from me? Since it looks like
I'm the author.
--
Anthony PERARD
- Re: [Qemu-devel] [PATCH 3/8] xen: defer call to xen_restrict until just before os_setup_post, (continued)
[Qemu-devel] [PATCH 1/8] xen: link against xentoolcore, Ian Jackson, 2017/10/09
[Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2017/10/09
[Qemu-devel] [PATCH 5/8] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2017/10/09
[Qemu-devel] [PATCH 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2017/10/09
[Qemu-devel] [PATCH 7/8] os-posix: Provide new -runas <uid>.<gid> facility, Ian Jackson, 2017/10/09
Re: [Qemu-devel] [PATCH v4 0/8] xen: xen-domid-restrict improvements, no-reply, 2017/10/09