[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v1 01/21] tpm-tis: remove unused hw_access argument
From: |
Stefan Berger |
Subject: |
[Qemu-devel] [PULL v1 01/21] tpm-tis: remove unused hw_access argument |
Date: |
Thu, 19 Oct 2017 14:02:35 -0400 |
From: Marc-André Lureau <address@hidden>
This argument is always false, simplify the code.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Stefan Berger <address@hidden>
Signed-off-by: Stefan Berger <address@hidden>
---
hw/tpm/tpm_tis.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
index d5118e7..a9e9cbd 100644
--- a/hw/tpm/tpm_tis.c
+++ b/hw/tpm/tpm_tis.c
@@ -615,9 +615,8 @@ static uint64_t tpm_tis_mmio_read(void *opaque, hwaddr addr,
* Write a value to a register of the TIS interface
* See specs pages 33-63 for description of the registers
*/
-static void tpm_tis_mmio_write_intern(void *opaque, hwaddr addr,
- uint64_t val, unsigned size,
- bool hw_access)
+static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
+ uint64_t val, unsigned size)
{
TPMState *s = opaque;
TPMTISEmuState *tis = &s->s.tis;
@@ -631,7 +630,7 @@ static void tpm_tis_mmio_write_intern(void *opaque, hwaddr
addr,
DPRINTF("tpm_tis: write.%u(%08x) = %08x\n", size, (int)addr, (int)val);
- if (locty == 4 && !hw_access) {
+ if (locty == 4) {
DPRINTF("tpm_tis: Access to locality 4 only allowed from hardware\n");
return;
}
@@ -942,12 +941,6 @@ static void tpm_tis_mmio_write_intern(void *opaque, hwaddr
addr,
}
}
-static void tpm_tis_mmio_write(void *opaque, hwaddr addr,
- uint64_t val, unsigned size)
-{
- tpm_tis_mmio_write_intern(opaque, addr, val, size, false);
-}
-
static const MemoryRegionOps tpm_tis_memory_ops = {
.read = tpm_tis_mmio_read,
.write = tpm_tis_mmio_write,
--
2.5.5
- [Qemu-devel] [PULL v1 00/21] Merge tpm 2017/10/19, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 16/21] tpm: remove locty_data from TPMState, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 01/21] tpm-tis: remove unused hw_access argument,
Stefan Berger <=
- [Qemu-devel] [PULL v1 21/21] tpm: move recv_data_callback to TPM interface, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 11/21] tpm: remove unused TPMBackendCmd, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 09/21] tpm: remove init() class method, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 04/21] tpm: lookup tpm backend class in tpm_driver_find_by_type(), Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 13/21] tpm: remove locty argument from receive_cb, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 12/21] tpm: remove needless cast, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 20/21] tpm: add a QOM TPM interface, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 06/21] tpm: remove tpm_register_driver(), Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 15/21] tpm-emulator: fix error handling, Stefan Berger, 2017/10/19
- [Qemu-devel] [PULL v1 14/21] tpm: add TPMBackendCmd to hold the request state, Stefan Berger, 2017/10/19