[Qemu-devel] [PATCH] build: Don't force preserving permissions on config-devices.mak.old

[Aaron Lindsay]

I get the following error when building on an NFSv3 filesystem:

% make -j8
  GEN     aarch64-softmmu/config-devices.mak.tmp
  GEN     config-host.h
[snip]
  GEN     qmp-marshal.c
  GEN     aarch64-softmmu/config-devices.mak
cp: preserving permissions for ‘aarch64-softmmu/config-devices.mak.old’: 
Operation not supported
make: *** Deleting file `aarch64-softmmu/config-devices.mak'
  GEN     qapi-types.c
[snip]
  CC      scsi/qemu-pr-helper.o
make: *** No rule to make target `config-all-devices.mak', needed by 
`subdir-aarch64-softmmu'.  Stop.
make: *** Waiting for unfinished jobs....

Ideally you would only build on a filesystem with proper support, but I haven't
been able to find a reason why preserving exact permissions is important in
this case.

Signed-off-by: Aaron Lindsay <address@hidden>
---
 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 9372742..952b6df 100644
--- a/Makefile
+++ b/Makefile
@@ -287,7 +287,7 @@ endif
        $(call quiet-command, if test -f $@; then \
          if cmp -s address@hidden $@; then \
            mv address@hidden $@; \
-           cp -p $@ address@hidden; \
+           cp $@ address@hidden; \
          else \
            if test -f address@hidden; then \
              echo "WARNING: $@ (user modified) out of date.";\
@@ -299,7 +299,7 @@ endif
          fi; \
         else \
          mv address@hidden $@; \
-         cp -p $@ address@hidden; \
+         cp $@ address@hidden; \
         fi,"GEN","$@");
 
 defconfig:
-- 
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.