qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/42] TPM: code cleanup & CRB device


From: Stefan Berger
Subject: Re: [Qemu-devel] [PATCH 00/42] TPM: code cleanup & CRB device
Date: Thu, 19 Oct 2017 19:55:43 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 10/19/2017 01:00 PM, Marc-André Lureau wrote:
Hi

----- Original Message -----
On 10/19/2017 10:44 AM, Stefan Berger wrote:
On 10/19/2017 10:33 AM, Marc-André Lureau wrote:
Hi Stefan

----- Original Message -----
On 10/09/2017 06:55 PM, Marc-André Lureau wrote:
Hi,

I accumulated a series of patch doing some TPM code cleanup while
doing review. I removed some dead code, simplified other parts, and
tried to isolate implementation of the backend and frontend by using a
new TPMIf interface. I solved a few issues, and added some FIXME for
what should be tackled.  Finally, I implemented a simple CRB device
(tpm 2.0) that is work in progress for now - it works fine with
passthrough, but swtpm/libtpms with win10 has some issues that need
more investigations.

seabios CRB support is required for TPM 2.0 & emulation
(https://mail.coreboot.org/pipermail/seabios/2017-October/011839.html)

Comments/review welcome!
Are you going to post a v2 soon?
I was wondering if you would take the patches that you already
reviewed for the next pull request. That way v2 would be smaller.
I'll take them up to 21/42.
Tested them and it seems to work fine. I'll post later today.

Did you have any more luck with win10 and tpm2 ?
I haven't had time so far to investigate further.

The summary was that Windows refuses to talk with a TPM2/TIS device (it doesn't 
even shows up in device list), while TPM2/CRB is being recognized and 
communicated with. However, there are some failure with swtpm/libtpms that are 
unclear, and will require more verbosity in libtpms. I plan to resume this 
effort in a few weeks.

TPM1.2 + TIS seems good.
TPM 2 + CRB seems to have a problem with a key handle 0x81 00 00 01.

   Stefan
Thanks





reply via email to

[Prev in Thread] Current Thread [Next in Thread]