[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements
From: |
Ian Jackson |
Subject: |
Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements |
Date: |
Fri, 20 Oct 2017 11:32:59 +0100 |
address@hidden writes ("Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict
improvements"):
> This series seems to have some coding style problems. See output below for
> more information:
No, it doesn't have coding style problems. At least, this mail
contains only one complaint which is this:
> Checking PATCH 7/8: os-posix: Provide new -runas <uid>.<gid> facility...
> ERROR: consider using qemu_strtoul in preference to strtoul
> #45: FILE: os-posix.c:142:
> + lv = strtoul(optarg, &ep, 0); /* can't qemu_strtoul, want *ep=='.' */
This is a false positive as you can see from the comment.
Ian.
- Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements, (continued)
- Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements, Ian Jackson, 2017/10/20
- [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore, Ian Jackson, 2017/10/20
- [Qemu-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash, Ian Jackson, 2017/10/20
- [Qemu-devel] [PATCH v5.1 3/8] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2017/10/20
- [Qemu-devel] [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2017/10/20
- [Qemu-devel] [PATCH v5.1 4/8] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2017/10/20
- [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2017/10/20
- [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2017/10/20
- [Qemu-devel] [PATCH v5.1 5/8] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2017/10/20
Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements, no-reply, 2017/10/21
- Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements,
Ian Jackson <=